Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.cc

Issue 2146223002: Refactor WorkerPoolCreationArgs to a Read-Only WorkerPoolParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WorkerPoolParams -> SchedulerWorkerPoolParams and Some Cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_pool_impl.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.cc b/base/task_scheduler/scheduler_worker_pool_impl.cc
index 06933eb32db62386195ba3619fd71c03914346fd..9f521e229cabb9dd7c52abcc7bc92be9d7b9aa69 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.cc
+++ b/base/task_scheduler/scheduler_worker_pool_impl.cc
@@ -227,17 +227,16 @@ SchedulerWorkerPoolImpl::~SchedulerWorkerPoolImpl() {
// static
std::unique_ptr<SchedulerWorkerPoolImpl> SchedulerWorkerPoolImpl::Create(
- StringPiece name,
- ThreadPriority thread_priority,
- size_t max_threads,
- IORestriction io_restriction,
+ const SchedulerWorkerPoolParams& params,
const ReEnqueueSequenceCallback& re_enqueue_sequence_callback,
TaskTracker* task_tracker,
DelayedTaskManager* delayed_task_manager) {
std::unique_ptr<SchedulerWorkerPoolImpl> worker_pool(
- new SchedulerWorkerPoolImpl(name, io_restriction, task_tracker,
- delayed_task_manager));
- if (worker_pool->Initialize(thread_priority, max_threads,
+ new SchedulerWorkerPoolImpl(params.name(),
+ params.io_restriction(),
+ task_tracker, delayed_task_manager));
+ if (worker_pool->Initialize(params.thread_priority(),
+ params.max_threads(),
re_enqueue_sequence_callback)) {
return worker_pool;
}
@@ -399,8 +398,9 @@ void SchedulerWorkerPoolImpl::SchedulerWorkerDelegateImpl::OnMainEntry(
tls_current_worker.Get().Set(worker);
tls_current_worker_pool.Get().Set(outer_);
- ThreadRestrictions::SetIOAllowed(outer_->io_restriction_ ==
- IORestriction::ALLOWED);
+ ThreadRestrictions::SetIOAllowed(
+ outer_->io_restriction_ ==
+ SchedulerWorkerPoolParams::IORestriction::ALLOWED);
}
scoped_refptr<Sequence>
@@ -486,7 +486,7 @@ bool SchedulerWorkerPoolImpl::SchedulerWorkerDelegateImpl::CanDetach(
SchedulerWorkerPoolImpl::SchedulerWorkerPoolImpl(
StringPiece name,
- IORestriction io_restriction,
+ SchedulerWorkerPoolParams::IORestriction io_restriction,
TaskTracker* task_tracker,
DelayedTaskManager* delayed_task_manager)
: name_(name.as_string()),

Powered by Google App Engine
This is Rietveld 408576698