Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: base/task_scheduler/scheduler_service_thread_unittest.cc

Issue 2146223002: Refactor WorkerPoolCreationArgs to a Read-Only WorkerPoolParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/scheduler_service_thread.h" 5 #include "base/task_scheduler/scheduler_service_thread.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/location.h" 11 #include "base/location.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/memory/ptr_util.h" 13 #include "base/memory/ptr_util.h"
14 #include "base/memory/ref_counted.h" 14 #include "base/memory/ref_counted.h"
15 #include "base/synchronization/waitable_event.h" 15 #include "base/synchronization/waitable_event.h"
16 #include "base/task_scheduler/delayed_task_manager.h" 16 #include "base/task_scheduler/delayed_task_manager.h"
17 #include "base/task_scheduler/scheduler_worker_pool_impl.h" 17 #include "base/task_scheduler/scheduler_worker_pool_impl.h"
18 #include "base/task_scheduler/sequence.h" 18 #include "base/task_scheduler/sequence.h"
19 #include "base/task_scheduler/task.h" 19 #include "base/task_scheduler/task.h"
20 #include "base/task_scheduler/task_tracker.h" 20 #include "base/task_scheduler/task_tracker.h"
21 #include "base/task_scheduler/task_traits.h" 21 #include "base/task_scheduler/task_traits.h"
22 #include "base/task_scheduler/worker_pool_params.h"
22 #include "base/time/time.h" 23 #include "base/time/time.h"
23 #include "testing/gtest/include/gtest/gtest.h" 24 #include "testing/gtest/include/gtest/gtest.h"
24 25
25 namespace base { 26 namespace base {
26 namespace internal { 27 namespace internal {
27 namespace { 28 namespace {
28 29
29 // The goal of the tests here is to verify the behavior of the Service Thread. 30 // The goal of the tests here is to verify the behavior of the Service Thread.
30 // Some tests may be better part of DelayedTaskManager unit tests depending on 31 // Some tests may be better part of DelayedTaskManager unit tests depending on
31 // the nature of the test. 32 // the nature of the test.
(...skipping 15 matching lines...) Expand all
47 // 3) Short waits sufficiently cover longer waits. Having tests run quickly is 48 // 3) Short waits sufficiently cover longer waits. Having tests run quickly is
48 // desirable. Since the tests can't change the behavior of timed waiting, the 49 // desirable. Since the tests can't change the behavior of timed waiting, the
49 // delay durations should be reasonably short on the order of hundreds of 50 // delay durations should be reasonably short on the order of hundreds of
50 // milliseconds. 51 // milliseconds.
51 class TaskSchedulerServiceThreadTest : public testing::Test { 52 class TaskSchedulerServiceThreadTest : public testing::Test {
52 protected: 53 protected:
53 TaskSchedulerServiceThreadTest() : delayed_task_manager_(Bind(&DoNothing)) {} 54 TaskSchedulerServiceThreadTest() : delayed_task_manager_(Bind(&DoNothing)) {}
54 55
55 void SetUp() override { 56 void SetUp() override {
56 scheduler_worker_pool_ = SchedulerWorkerPoolImpl::Create( 57 scheduler_worker_pool_ = SchedulerWorkerPoolImpl::Create(
57 "TestWorkerPoolForSchedulerServiceThread", ThreadPriority::BACKGROUND, 58 WorkerPoolParams("TestWorkerPoolForSchedulerServiceThread",
58 1u, SchedulerWorkerPoolImpl::IORestriction::DISALLOWED, 59 ThreadPriority::BACKGROUND,
60 SchedulerWorkerPoolImpl::IORestriction::DISALLOWED,
61 1u),
59 Bind(&ReEnqueueSequenceCallback), &task_tracker_, 62 Bind(&ReEnqueueSequenceCallback), &task_tracker_,
60 &delayed_task_manager_); 63 &delayed_task_manager_);
61 ASSERT_TRUE(scheduler_worker_pool_); 64 ASSERT_TRUE(scheduler_worker_pool_);
62 service_thread_ = SchedulerServiceThread::Create( 65 service_thread_ = SchedulerServiceThread::Create(
63 &task_tracker_, &delayed_task_manager_); 66 &task_tracker_, &delayed_task_manager_);
64 ASSERT_TRUE(service_thread_); 67 ASSERT_TRUE(service_thread_);
65 } 68 }
66 69
67 void TearDown() override { 70 void TearDown() override {
68 scheduler_worker_pool_->JoinForTesting(); 71 scheduler_worker_pool_->JoinForTesting();
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 177
175 // Now wait for the second task to be fired. 178 // Now wait for the second task to be fired.
176 event2.Wait(); 179 event2.Wait();
177 180
178 // Which should only have fired after |delay2| was expired. 181 // Which should only have fired after |delay2| was expired.
179 EXPECT_GE(TimeTicks::Now() - test_begin_time, delay2); 182 EXPECT_GE(TimeTicks::Now() - test_begin_time, delay2);
180 } 183 }
181 184
182 } // namespace internal 185 } // namespace internal
183 } // namespace base 186 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698