Add an option to make blink media logging verbose

Add an option to make blink media logging verbose

We want HTMLMediaElement and MSE media logging to be always enabled on
Chromecast, since we are getting these logged into system logs and
use them to investigate bugs when we receive feedback reports from
users, so we want these logs to use VLOG and be present in our release
builds. We'll define VERBOSE_BLINK_MEDIA_LOGGING for Chromecast builds
only, so that other flavors of Chromium/Chrome are not affected by this
in any way.

Committed: https://crrev.com/a341d473bcb2cf23d76708cd277002dabc1643d0
Cr-Commit-Position: refs/heads/master@{#406349}

[servolk, 2016-07-13 21:47:05]

Description was changed from

==========
Add an option to make blink media logging verbose

We want HTMLMediaElement and MSE media logging to be always enabled on
Chromecast, since we are getting these logged into system logs and
use them to investigate bugs when we receive feedback reports from
users, so we want these logs to use VLOG and be present in our release
builds. We'll define VERBOSE_BLINK_MEDIA_LOGGING for Chromecast builds
only, so that other flavors of Chromium/Chrome are not affected by this
in any way.
==========

to

==========
Add an option to make blink media logging verbose

We want HTMLMediaElement and MSE media logging to be always enabled on
Chromecast, since we are getting these logged into system logs and
use them to investigate bugs when we receive feedback reports from
users, so we want these logs to use VLOG and be present in our release
builds. We'll define VERBOSE_BLINK_MEDIA_LOGGING for Chromecast builds
only, so that other flavors of Chromium/Chrome are not affected by this
in any way.
==========

[servolk, 2016-07-13 21:47:06]

servolk@chromium.org changed reviewers:
+ mlamouri@chromium.org

[servolk, 2016-07-15 00:50:40]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 00:51:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 03:16:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 03:16:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mlamouri (slow - plz ping), 2016-07-15 15:47:24]

What about doing:
```
#ifndef MEDIA_LOG
#define MEDIA_LOG VLOG(3)
#endif
```

(and same for mediasource)

That way, chrome cast can force the value to something else like VLOG(3) instead
of adding yet another macro?

[servolk, 2016-07-15 17:09:56]

On 2016/07/15 15:47:24, Mounir Lamouri wrote:
> What about doing:
> ```
> #ifndef MEDIA_LOG
> #define MEDIA_LOG VLOG(3)
> #endif
> ```
> 
> (and same for mediasource)
> 
> That way, chrome cast can force the value to something else like VLOG(3)
instead
> of adding yet another macro?

Sure, we can do this. Let's just use BLINK_MEDIA_LOG instead of the generic
MEDIA_LOG name, to avoid potential conflicts with the MEDIA_LOG defined in the
src/media/.
I've also got rid of separate macros that were used for
MediaSource/SourceBuffer, since it's easy to control what gets logged by
adjusting the value of --vmodule command-line parameters.

[mlamouri (slow - plz ping), 2016-07-18 09:39:25]

I think it would be better if you didn't merge the three LOG macros. MediaSource
and MediaBuffer are very different from HTMLMediaElement. If one debug one of
these things, they will not want the rest to pollute their logs. I understand
that chrome cast is interested to have the three of these but it wouldn't cost
much on your side to set the three macros.

[servolk, 2016-07-18 16:35:43]

On 2016/07/18 09:39:25, Mounir Lamouri wrote:
> I think it would be better if you didn't merge the three LOG macros.
MediaSource
> and MediaBuffer are very different from HTMLMediaElement. If one debug one of
> these things, they will not want the rest to pollute their logs. I understand
> that chrome cast is interested to have the three of these but it wouldn't cost
> much on your side to set the three macros.

Ok, I brought back the three separate macros (and since now the BLINK_MEDIA_LOG
is only used by the MediaElement, I put it back into .cpp file), PTAL.

[mlamouri (slow - plz ping), 2016-07-19 10:45:33]

lgtm, thanks! :)

[servolk, 2016-07-19 15:34:42]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2016-07-19 15:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 18:10:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 18:10:21]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[servolk, 2016-07-19 18:12:07]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2016-07-19 18:13:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 19:37:41]

Description was changed from

==========
Add an option to make blink media logging verbose

We want HTMLMediaElement and MSE media logging to be always enabled on
Chromecast, since we are getting these logged into system logs and
use them to investigate bugs when we receive feedback reports from
users, so we want these logs to use VLOG and be present in our release
builds. We'll define VERBOSE_BLINK_MEDIA_LOGGING for Chromecast builds
only, so that other flavors of Chromium/Chrome are not affected by this
in any way.
==========

to

==========
Add an option to make blink media logging verbose

We want HTMLMediaElement and MSE media logging to be always enabled on
Chromecast, since we are getting these logged into system logs and
use them to investigate bugs when we receive feedback reports from
users, so we want these logs to use VLOG and be present in our release
builds. We'll define VERBOSE_BLINK_MEDIA_LOGGING for Chromecast builds
only, so that other flavors of Chromium/Chrome are not affected by this
in any way.
==========

[commit-bot: I haz the power, 2016-07-19 19:37:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-19 19:37:50]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 19:39:06]

Description was changed from

==========
Add an option to make blink media logging verbose

We want HTMLMediaElement and MSE media logging to be always enabled on
Chromecast, since we are getting these logged into system logs and
use them to investigate bugs when we receive feedback reports from
users, so we want these logs to use VLOG and be present in our release
builds. We'll define VERBOSE_BLINK_MEDIA_LOGGING for Chromecast builds
only, so that other flavors of Chromium/Chrome are not affected by this
in any way.
==========

to

==========
Add an option to make blink media logging verbose

We want HTMLMediaElement and MSE media logging to be always enabled on
Chromecast, since we are getting these logged into system logs and
use them to investigate bugs when we receive feedback reports from
users, so we want these logs to use VLOG and be present in our release
builds. We'll define VERBOSE_BLINK_MEDIA_LOGGING for Chromecast builds
only, so that other flavors of Chromium/Chrome are not affected by this
in any way.

Committed: https://crrev.com/a341d473bcb2cf23d76708cd277002dabc1643d0
Cr-Commit-Position: refs/heads/master@{#406349}
==========

[commit-bot: I haz the power, 2016-07-19 19:39:09]

Patchset 4 (id:??) landed as
https://crrev.com/a341d473bcb2cf23d76708cd277002dabc1643d0
Cr-Commit-Position: refs/heads/master@{#406349}