Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2146183002:
Sync up chromium.memory builder configs with trybots. (Closed)
|
Created:
4 years, 5 months ago by Lei Zhang Modified:
4 years, 5 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSync up chromium.memory builder configs with trybots.
BUG=627847
Committed: https://crrev.com/6b0cab359ccca1dc7c563cc42a77015afe9bfa34
Cr-Commit-Position: refs/heads/master@{#405426}
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comment #
Total comments: 5
Patch Set 3 : 'trybot' #Messages
Total messages: 19 (8 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thestig@chromium.org changed reviewers: + dpranke@chromium.org
Is this all I have to do these days to change bot configs? Do I need to follow up with a trooper for a master restart?
https://codereview.chromium.org/2146183002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2146183002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:372: 'Linux ASan LSan Builder': 'swarming_asan_lsan_gn_release_bot', You should change this to 'swarming_asan_lsan_gn_release_trybot' instead to match the entry on line 723 for linux_chromium_asan_rel_ng instead, if you wanted DCHECKs on the waterfall. Or change the linux_chromium_asan_rel_ng entry to 'swarming_asan_lsan_gn_release_bot' to match this one. Same for the other builders.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2146183002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2146183002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:372: 'Linux ASan LSan Builder': 'swarming_asan_lsan_gn_release_bot', On 2016/07/13 22:32:50, Dirk Pranke wrote: > You should change this to 'swarming_asan_lsan_gn_release_trybot' instead to > match the entry on line 723 for linux_chromium_asan_rel_ng instead, if you > wanted DCHECKs on the waterfall. > > Or change the linux_chromium_asan_rel_ng entry to > 'swarming_asan_lsan_gn_release_bot' to match this one. > > Same for the other builders. Done, except Mac, where there isn't a matching builder.
https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:529: 'Linux ASAN Builder': 'swarming_asan_lsan_gn_release_bot', There's another bot that's using swarming_asan_lsan_gn_release_bot, so I'm leaving it alone.
https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1484: 'dcheck_always_on', did you leave this in intentionally?
https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1484: 'dcheck_always_on', On 2016/07/14 01:00:26, Dirk Pranke wrote: > did you leave this in intentionally? Yes. This is the mac bot, and there's no equivalent trybot configuration. The Mac ASAN trybot doesn't do LSAN. (I don't actually know why)
lgtm w/ comment addressed. https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1484: 'dcheck_always_on', On 2016/07/14 01:03:27, Lei Zhang wrote: > On 2016/07/14 01:00:26, Dirk Pranke wrote: > > did you leave this in intentionally? > > Yes. This is the mac bot, and there's no equivalent trybot configuration. The > Mac ASAN trybot doesn't do LSAN. (I don't actually know why) Okay. Please rename the config to 'release_trybot', though; I don't want something called 'release_bot' to have dchecks enabled.
https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2146183002/diff/20001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1484: 'dcheck_always_on', On 2016/07/14 01:22:19, Dirk Pranke wrote: > On 2016/07/14 01:03:27, Lei Zhang wrote: > > On 2016/07/14 01:00:26, Dirk Pranke wrote: > > > did you leave this in intentionally? > > > > Yes. This is the mac bot, and there's no equivalent trybot configuration. The > > Mac ASAN trybot doesn't do LSAN. (I don't actually know why) > > Okay. Please rename the config to 'release_trybot', though; I don't want > something called 'release_bot' to have dchecks enabled. Done.
The CQ bit was checked by thestig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2146183002/#ps40001 (title: "'trybot'")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Sync up chromium.memory builder configs with trybots. BUG=627847 ========== to ========== Sync up chromium.memory builder configs with trybots. BUG=627847 Committed: https://crrev.com/6b0cab359ccca1dc7c563cc42a77015afe9bfa34 Cr-Commit-Position: refs/heads/master@{#405426} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6b0cab359ccca1dc7c563cc42a77015afe9bfa34 Cr-Commit-Position: refs/heads/master@{#405426} |
