Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2146163005: [css-tables] Don't use internal layout structure when iterating all rows (Closed)

Created:
4 years, 5 months ago by dgrogan
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-tables] Don't use internal layout structure when iterating all rows Instead use basic firstChild and nextSibling. This avoids a crash when the internal layout structure is dirty. Add DCHECK to discourage future mistakes. BUG=627839 Committed: https://crrev.com/6861fa525cd261302ed9a6f0e4ec420c682d2a8c Cr-Commit-Position: refs/heads/master@{#405555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width-crash.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width-crash-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgrogan
Emil, could you review this?
4 years, 5 months ago (2016-07-14 03:06:40 UTC) #2
eae
OK, LGTM
4 years, 5 months ago (2016-07-14 16:34:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146163005/1
4 years, 5 months ago (2016-07-14 16:34:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/245139)
4 years, 5 months ago (2016-07-14 18:19:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146163005/1
4 years, 5 months ago (2016-07-14 19:48:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 20:36:58 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 20:39:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6861fa525cd261302ed9a6f0e4ec420c682d2a8c
Cr-Commit-Position: refs/heads/master@{#405555}

Powered by Google App Engine
This is Rietveld 408576698