Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: tests/PDFPrimitivesTest.cpp

Issue 2146103004: SkPDF: re-work SkPDFUtils::FloatToDecimal (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2016-07-14 (Thursday) 15:50:08 EDT Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/pdf/SkPDFUtils.cpp ('K') | « src/pdf/SkPDFUtils.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PDFPrimitivesTest.cpp
diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp
index 9e2a89e60953b067faf69e588a05bad9b6a07657..2557ca06a30687b7f6c1953e2721e18b65f13904 100644
--- a/tests/PDFPrimitivesTest.cpp
+++ b/tests/PDFPrimitivesTest.cpp
@@ -210,7 +210,7 @@ static void TestPDFUnion(skiatest::Reporter* reporter) {
ASSERT_EMIT_EQ(reporter, biggerScalar, "50000000");
SkPDFUnion smallestScalar = SkPDFUnion::Scalar(1.0f / 65536);
- ASSERT_EMIT_EQ(reporter, smallestScalar, ".0000152587890");
+ ASSERT_EMIT_EQ(reporter, smallestScalar, ".0000152587891");
tomhudson 2016/07/15 20:45:42 One digit change? How did this ever work? Or is th
hal.canary 2016/07/17 02:33:42 Both values round back to the original float value
SkPDFUnion stringSimple = SkPDFUnion::String("test ) string ( foo");
ASSERT_EMIT_EQ(reporter, stringSimple, "(test \\) string \\( foo)");
« src/pdf/SkPDFUtils.cpp ('K') | « src/pdf/SkPDFUtils.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698