Update RT views and framebuffer in vulkan after mipmaping

Update RT views and framebuffer in vulkan after mipmaping

I've also changed it so all attachment views (texture, color, and resolve) are created separately and not shared with each other. This just added a lot more complexity than we were probably even saving in time.

A quick fix to make sure we don't reuse keys in resource tracking also
got merged into this change.

BUG=skia:5223
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146103002

Committed: https://skia.googlesource.com/skia/+/50ead53ac97deb23310916e3736c3f5e2d8f7f4b

[egdaniel, 2016-07-13 20:26:58]

Description was changed from

==========
Update RT views and framebuffer in vulkan after mipmaping

A quick fix to make sure we don't reuse keys in resource tracking also
got merged into this change.

BUG=skia:
==========

to

==========
Update RT views and framebuffer in vulkan after mipmaping

A quick fix to make sure we don't reuse keys in resource tracking also
got merged into this change.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146103002
==========

[egdaniel, 2016-07-13 20:29:25]

Description was changed from

==========
Update RT views and framebuffer in vulkan after mipmaping

A quick fix to make sure we don't reuse keys in resource tracking also
got merged into this change.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146103002
==========

to

==========
Update RT views and framebuffer in vulkan after mipmaping

I've also changed it so all attachment views (texture, color, and resolve) are
created separately and not shared with each other. This just added a lot more
complexity than we were probably even saving in time.

A quick fix to make sure we don't reuse keys in resource tracking also
got merged into this change.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146103002
==========

[egdaniel, 2016-07-13 20:30:11]

egdaniel@google.com changed reviewers:
+ brianosman@google.com, jvanverth@google.com

[jvanverth1, 2016-07-13 21:01:45]

lgtm + comments

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkBuffer.h
File src/gpu/vk/GrVkBuffer.h (left):

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkBuffer.h#old...
src/gpu/vk/GrVkBuffer.h:71: void freeGPUData(const GrVkGpu* gpu) const;
I ran into this too -- I'm not sure how it slipped through.

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkResource.h
File src/gpu/vk/GrVkResource.h (right):

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkResource.h#n...
src/gpu/vk/GrVkResource.h:63: static SkRandom fRandom;
This declaration of fRandom should go away.

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkTexture.cpp
File src/gpu/vk/GrVkTexture.cpp (right):

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkTexture.cpp#...
src/gpu/vk/GrVkTexture.cpp:178: // Does this even make sense for rendertargets?
Remove this comment? Apparently it does make sense...

[egdaniel, 2016-07-13 21:04:58]

Description was changed from

==========
Update RT views and framebuffer in vulkan after mipmaping

I've also changed it so all attachment views (texture, color, and resolve) are
created separately and not shared with each other. This just added a lot more
complexity than we were probably even saving in time.

A quick fix to make sure we don't reuse keys in resource tracking also
got merged into this change.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146103002
==========

to

==========
Update RT views and framebuffer in vulkan after mipmaping

I've also changed it so all attachment views (texture, color, and resolve) are
created separately and not shared with each other. This just added a lot more
complexity than we were probably even saving in time.

A quick fix to make sure we don't reuse keys in resource tracking also
got merged into this change.

BUG=skia:5223
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146103002
==========

[egdaniel, 2016-07-13 21:06:35]

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkResource.h
File src/gpu/vk/GrVkResource.h (right):

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkResource.h#n...
src/gpu/vk/GrVkResource.h:63: static SkRandom fRandom;
On 2016/07/13 21:01:45, jvanverth1 wrote:
> This declaration of fRandom should go away.

Done.

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkTexture.cpp
File src/gpu/vk/GrVkTexture.cpp (right):

https://codereview.chromium.org/2146103002/diff/1/src/gpu/vk/GrVkTexture.cpp#...
src/gpu/vk/GrVkTexture.cpp:178: // Does this even make sense for rendertargets?
On 2016/07/13 21:01:45, jvanverth1 wrote:
> Remove this comment? Apparently it does make sense...

Done.

[egdaniel, 2016-07-13 21:06:40]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-07-13 21:06:40]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2146103002/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-07-13 21:06:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 21:23:28]

Description was changed from

==========
Update RT views and framebuffer in vulkan after mipmaping

I've also changed it so all attachment views (texture, color, and resolve) are
created separately and not shared with each other. This just added a lot more
complexity than we were probably even saving in time.

A quick fix to make sure we don't reuse keys in resource tracking also
got merged into this change.

BUG=skia:5223
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146103002
==========

to

==========
Update RT views and framebuffer in vulkan after mipmaping

I've also changed it so all attachment views (texture, color, and resolve) are
created separately and not shared with each other. This just added a lot more
complexity than we were probably even saving in time.

A quick fix to make sure we don't reuse keys in resource tracking also
got merged into this change.

BUG=skia:5223
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146103002

Committed:
https://skia.googlesource.com/skia/+/50ead53ac97deb23310916e3736c3f5e2d8f7f4b
==========

[commit-bot: I haz the power, 2016-07-13 21:23:30]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/50ead53ac97deb23310916e3736c3f5e2d8f7f4b