Support loading dart-ext from within a package when using a package map

Support loading dart-ext from within a package when using a package map

Fixes https://github.com/dart-lang/sdk/issues/26879

When a dart-ext is imported from within a package: library we need to fully resolve the package: to a file: (or whatever scheme:) so that we can locate the shared object for the extension file.

This CL sends this request through the service isolate so that the package: can be resolved even when a package config is being used.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/05c1eac65d8678bc1f9fa688d0e119f56a3d0f90

[Cutch, 2016-07-13 19:55:52]

Description was changed from

==========
Support loading dart-ext from within a package when using a package map


status file tweaks

BUG=
==========

to

==========
Support loading dart-ext from within a package when using a package map

Fixes https://github.com/dart-lang/sdk/issues/26879
==========

[Cutch, 2016-07-13 19:55:52]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com

[Cutch, 2016-07-13 20:01:04]

Description was changed from

==========
Support loading dart-ext from within a package when using a package map

Fixes https://github.com/dart-lang/sdk/issues/26879
==========

to

==========
Support loading dart-ext from within a package when using a package map

Fixes https://github.com/dart-lang/sdk/issues/26879

When a dart-ext is imported from within a package: library we need to fully
resolve the package: to a file: (or whatever scheme:) so that we can locate the
shared object for the extension file. 

This CL sends this request through the service isolate so that the package: can
be resolved even when a package config is being used.
==========

[siva, 2016-07-13 21:25:14]

lgtm

https://codereview.chromium.org/2146093002/diff/40001/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2146093002/diff/40001/runtime/bin/loader.cc#n...
runtime/bin/loader.cc:294: const intptr_t _Dart_kImportExtension = 9;
This is repeated twice in this file whu not put it on the top (global scope) or
in a header file.

https://codereview.chromium.org/2146093002/diff/40001/runtime/bin/loader.cc#n...
runtime/bin/loader.cc:297: Dart_Handle library =
Dart_LookupLibrary(library_uri);
The return library object could be an error object, should we check for that and
bail out too.

[Cutch, 2016-07-13 22:18:24]

https://codereview.chromium.org/2146093002/diff/40001/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2146093002/diff/40001/runtime/bin/loader.cc#n...
runtime/bin/loader.cc:294: const intptr_t _Dart_kImportExtension = 9;
On 2016/07/13 21:25:14, siva wrote:
> This is repeated twice in this file whu not put it on the top (global scope)
or
> in a header file.

Done.

https://codereview.chromium.org/2146093002/diff/40001/runtime/bin/loader.cc#n...
runtime/bin/loader.cc:297: Dart_Handle library =
Dart_LookupLibrary(library_uri);
On 2016/07/13 21:25:14, siva wrote:
> The return library object could be an error object, should we check for that
and
> bail out too.

I check for it before scheduling with the service isolate.

[Cutch, 2016-07-13 22:20:14]

Description was changed from

==========
Support loading dart-ext from within a package when using a package map

Fixes https://github.com/dart-lang/sdk/issues/26879

When a dart-ext is imported from within a package: library we need to fully
resolve the package: to a file: (or whatever scheme:) so that we can locate the
shared object for the extension file. 

This CL sends this request through the service isolate so that the package: can
be resolved even when a package config is being used.
==========

to

==========
Support loading dart-ext from within a package when using a package map

Fixes https://github.com/dart-lang/sdk/issues/26879

When a dart-ext is imported from within a package: library we need to fully
resolve the package: to a file: (or whatever scheme:) so that we can locate the
shared object for the extension file.

This CL sends this request through the service isolate so that the package: can
be resolved even when a package config is being used.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/05c1eac65d8678bc1f9fa688d0e119f56a3d0f90
==========

[Cutch, 2016-07-13 22:20:16]

Committed patchset #3 (id:40001) manually as
05c1eac65d8678bc1f9fa688d0e119f56a3d0f90 (presubmit successful).