src/core/SkPicturePlayback.cpp - Issue 2146073003: Creating framework for drawShadowedPicture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPicturePlayback.cpp

Issue 2146073003: Creating framework for drawShadowedPicture (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Made changes to better hide changes from public Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPicturePlayback.cpp

diff --git a/src/core/SkPicturePlayback.cpp b/src/core/SkPicturePlayback.cpp

index 60c4fe898dac64412654fbbf55c72f8bfaecef13..1296f366f5ba46b89597941e12ccd3efcb3234f0 100644

--- a/src/core/SkPicturePlayback.cpp

+++ b/src/core/SkPicturePlayback.cpp

@@ -617,9 +617,11 @@ void SkPicturePlayback::handleOp(SkReadBuffer* reader,

canvas->translate(dx, dy);

} break;

case TRANSLATE_Z: {

+#ifdef SK_USE_SHADOWS

SkScalar dz = reader->readScalar();

canvas->translateZ(dz);

- }

+#endif

+ } break;

default:

SkASSERTF(false, "Unknown draw type: %d", op);

}