Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: src/core/SkPictureFlat.h

Issue 2146073003: Creating framework for drawShadowedPicture (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Missed error Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/SkPictureFlat.h
diff --git a/src/core/SkPictureFlat.h b/src/core/SkPictureFlat.h
index 125d4e95e84f9c60528ec39bfb6e92ad32d2e09d..22bd7a6b1f89074ab390eadab6e42e79dc3f1c1f 100644
--- a/src/core/SkPictureFlat.h
+++ b/src/core/SkPictureFlat.h
@@ -17,6 +17,13 @@
#include "SkPtrRecorder.h"
#include "SkTDynamicHash.h"
+/*
+ * Note: While adding new DrawTypes, it is necessary to add to the end of this list
+ * and update LAST_DRAWTYPE_ENUM to avoid having the code read older skp's wrong.
jvanverth1 2016/07/18 15:02:26 Nit: No apostrophe.
vjiaoblack 2016/07/18 16:51:06 Done. Well, it's an arguable grammar issue, right?
+ * (which can cause segfaults)
+ *
+ * Reordering can be done during version updates.
+ */
enum DrawType {
UNUSED,
CLIP_PATH,
@@ -83,7 +90,9 @@ enum DrawType {
TRANSLATE_Z,
- LAST_DRAWTYPE_ENUM = TRANSLATE_Z
+ DRAW_SHADOWED_PICTURE_LIGHTS,
+
+ LAST_DRAWTYPE_ENUM = DRAW_SHADOWED_PICTURE_LIGHTS
};
// In the 'match' method, this constant will match any flavor of DRAW_BITMAP*

Powered by Google App Engine
This is Rietveld 408576698