Dont allocate a new image which already has mip levels, when regenerating vulkan mipmaps

Dont allocate a new image which already has mip levels, when regenerating vulkan mipmaps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146063008

Committed: https://skia.googlesource.com/skia/+/7ac5da853457b032781cf865ba018de78508edb7

[egdaniel, 2016-07-15 15:34:49]

Description was changed from

==========
Dont allocate a new image which already has mip levels, when regenerating vulkan
mipmaps

BUG=skia:
==========

to

==========
Dont allocate a new image which already has mip levels, when regenerating vulkan
mipmaps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146063008
==========

[egdaniel, 2016-07-15 15:36:23]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[jvanverth1, 2016-07-15 18:57:30]

lgtm, just one suggestion

https://codereview.chromium.org/2146063008/diff/1/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/2146063008/diff/1/src/gpu/vk/GrVkGpu.cpp#newc...
src/gpu/vk/GrVkGpu.cpp:794: int width = tex->width();
Move inside the conditional?

[egdaniel, 2016-07-15 19:02:06]

https://codereview.chromium.org/2146063008/diff/1/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/2146063008/diff/1/src/gpu/vk/GrVkGpu.cpp#newc...
src/gpu/vk/GrVkGpu.cpp:794: int width = tex->width();
On 2016/07/15 18:57:30, jvanverth1 wrote:
> Move inside the conditional?

It is used in the while loop (doing the blits) as well

[jvanverth1, 2016-07-15 19:32:51]

https://codereview.chromium.org/2146063008/diff/1/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/2146063008/diff/1/src/gpu/vk/GrVkGpu.cpp#newc...
src/gpu/vk/GrVkGpu.cpp:794: int width = tex->width();
On 2016/07/15 19:02:06, egdaniel wrote:
> On 2016/07/15 18:57:30, jvanverth1 wrote:
> > Move inside the conditional?
> 
> It is used in the while loop (doing the blits) as well

Ah, it was hidden. Cool beans.

[egdaniel, 2016-07-15 20:18:57]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-07-15 20:19:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 20:41:44]

Description was changed from

==========
Dont allocate a new image which already has mip levels, when regenerating vulkan
mipmaps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146063008
==========

to

==========
Dont allocate a new image which already has mip levels, when regenerating vulkan
mipmaps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146063008

Committed:
https://skia.googlesource.com/skia/+/7ac5da853457b032781cf865ba018de78508edb7
==========

[commit-bot: I haz the power, 2016-07-15 20:41:45]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7ac5da853457b032781cf865ba018de78508edb7