Issue 2146063004: Remove failing assert in Function::ClearCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2146063004: Remove failing assert in Function::ClearCode. (Closed)

Created:
4 years, 5 months ago by rmacnak

Modified:
4 years, 5 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove failing assert in Function::ClearCode. Caching JIT snapshots may include functions with a zeroed usage counter that still have type feedback, e.g. due to code collection. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/d75da67de1b342de76080620f1534f311131d96d

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	runtime/vm/object.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	runtime/vm/object.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 5 months ago (2016-07-13 21:43:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d75da67de1b342de76080620f1534f311131d96d (presubmit successful).