Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2146063002: Fix vertex count estimate in GrTessellator. (Closed)

Created:
4 years, 5 months ago by Stephen White
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix vertex count estimate in GrTessellator. When we start a new MonotonePoly due to a handedness change, we don't need to increase the vertex count, since that edge (and vertex) has already been accounted for in the previous MonotonePoly. This was not a correctness issue, but was causing us to allocate extra vertices which would go unused. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146063002 Committed: https://skia.googlesource.com/skia/+/99f942e5505a663b0d355ad187484f15e3a9a83a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/gpu/GrTessellator.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Stephen White
Brian: PTAL. Thanks!
4 years, 5 months ago (2016-07-13 17:18:46 UTC) #5
bsalomon
4 years, 5 months ago (2016-07-13 17:24:09 UTC) #7
bsalomon
lgtm
4 years, 5 months ago (2016-07-13 17:24:13 UTC) #8
bsalomon
lgtm
4 years, 5 months ago (2016-07-13 17:24:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146063002/1
4 years, 5 months ago (2016-07-13 17:39:35 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:40:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/99f942e5505a663b0d355ad187484f15e3a9a83a

Powered by Google App Engine
This is Rietveld 408576698