Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2146053003: Avoid mishandling CSSPendingSubstitutionValues in CSS animations (Closed)

Created:
4 years, 5 months ago by alancutter (OOO until 2018)
Modified:
4 years, 5 months ago
CC:
darktears, Andy Mutton, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid mishandling CSSPendingSubstitutionValues in CSS animations This change ensures we have a code path for CSSPendingSubstitutionValues during animation, it does not attempt to perform the correct animated behaviour just yet. BUG=627756 Committed: https://crrev.com/f6ca1fb7dc6ea62d05099bc87b5a11f19f11a8ae Cr-Commit-Position: refs/heads/master@{#405699}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/animations/animate-shorthand-var-crash.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
alancutter (OOO until 2018)
4 years, 5 months ago (2016-07-14 04:43:21 UTC) #4
alancutter (OOO until 2018)
4 years, 5 months ago (2016-07-14 04:43:39 UTC) #5
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-14 05:06:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146053003/20001
4 years, 5 months ago (2016-07-14 05:31:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/255706)
4 years, 5 months ago (2016-07-14 07:41:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146053003/20001
4 years, 5 months ago (2016-07-15 03:12:37 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 04:34:55 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 04:35:01 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 04:37:55 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6ca1fb7dc6ea62d05099bc87b5a11f19f11a8ae
Cr-Commit-Position: refs/heads/master@{#405699}

Powered by Google App Engine
This is Rietveld 408576698