Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2146053002: PPC/s390: [ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when possible… (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when possible to avoid misses. Port b9a7b28163d0e5b86e2d750109b897654057197a Fixed minor register mapping issue in ppc/s390 files. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:576312 LOG=N Committed: https://crrev.com/31799674e2b5dd4a9be1d244f3ab38948a3ac677 Cr-Commit-Position: refs/heads/master@{#37725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-07-13 16:36:10 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-07-13 16:37:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146053002/1
4 years, 5 months ago (2016-07-13 16:37:27 UTC) #4
Igor Sheludko
lgtm. Thanks!
4 years, 5 months ago (2016-07-13 16:37:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 17:01:01 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:01:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31799674e2b5dd4a9be1d244f3ab38948a3ac677
Cr-Commit-Position: refs/heads/master@{#37725}

Powered by Google App Engine
This is Rietveld 408576698