chrome/browser/ui/task_manager/task_manager_table_model.h - Issue 2146033003: TableView: 3-phase ToggleSortOrder (sorted/reversed/unsorted)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/task_manager/task_manager_table_model.h

Issue 2146033003: TableView: 3-phase ToggleSortOrder (sorted/reversed/unsorted) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bug. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/task_manager/task_manager_table_model.h

diff --git a/chrome/browser/ui/task_manager/task_manager_table_model.h b/chrome/browser/ui/task_manager/task_manager_table_model.h

index e726e619f9a6994b6aaa936c8994b506303f924c..30cc0c15b347ec62e1b2791952ff1c1072c8d397 100644

--- a/chrome/browser/ui/task_manager/task_manager_table_model.h

+++ b/chrome/browser/ui/task_manager/task_manager_table_model.h

@@ -45,9 +45,7 @@ class TableViewDelegate {

virtual TableSortDescriptor GetSortDescriptor() const = 0;

- // As the name of |visible_column_index| implies, it must by the index of the

- // column in the visible columns array.

- virtual void ToggleSortOrder(int visible_column_index) = 0;

+ virtual void SetSortDescriptor(TableSortDescriptor sort_descriptor) = 0;

sky 2016/07/18 16:18:58 const TableSortDescriptor& ?

ncarter (slow) 2016/07/25 20:04:01 Done.

private:

DISALLOW_COPY_AND_ASSIGN(TableViewDelegate);

« no previous file with comments | « no previous file | chrome/browser/ui/task_manager/task_manager_table_model.cc » ('j') | ui/views/controls/table/table_view.h » ('J')