TableView: 3-phase ToggleSortOrder (sorted/reversed/unsorted)

ui/views/controls/table/table_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/table/table_view.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <map>
@@ skipping 216 matching lines @@
   UpdateVisibleColumnSizes();
   PreferredSizeChanged();
   SchedulePaint();
   if (header_)
     header_->SchedulePaint();
 }
 
 void TableView::ToggleSortOrder(int visible_column_index) {
   DCHECK(visible_column_index >= 0 &&
          visible_column_index < static_cast<int>(visible_columns_.size()));
-  if (!visible_columns_[visible_column_index].column.sortable)
+  const ui::TableColumn& column = visible_columns_[visible_column_index].column;
+  if (!column.sortable)
     return;
-  const int column_id = visible_columns_[visible_column_index].column.id;
   SortDescriptors sort(sort_descriptors_);
-  if (!sort.empty() && sort[0].column_id == column_id) {
-    sort[0].ascending = !sort[0].ascending;
+  if (!sort.empty() && sort[0].column_id == column.id) {
+    if (sort[0].ascending == column.initial_sort_is_ascending) {
+      // First toggle inverts the order.
+      sort[0].ascending = !sort[0].ascending;
+    } else {
+      // Second toggle clears the sort.
+      sort.clear();
+    }
   } else {
-    SortDescriptor descriptor(column_id, visible_columns_[
-        visible_column_index].column.initial_sort_is_ascending);
+    SortDescriptor descriptor(column.id, column.initial_sort_is_ascending);
     sort.insert(sort.begin(), descriptor);
     // Only persist two sort descriptors.
     if (sort.size() > 2)
       sort.resize(2);
   }
   SetSortDescriptors(sort);
 }
 
+void TableView::SetSortDescriptors(const SortDescriptors& sort_descriptors) {
+  sort_descriptors_ = sort_descriptors;
+  SortItemsAndUpdateMapping();
+  if (header_)
+    header_->SchedulePaint();
+}
+
 bool TableView::IsColumnVisible(int id) const {
   for (size_t i = 0; i < visible_columns_.size(); ++i) {
     if (visible_columns_[i].column.id == id)
       return true;
   }
   return false;
 }
 
 void TableView::AddColumn(const ui::TableColumn& col) {
   DCHECK(!HasColumn(col.id));
@@ skipping 369 matching lines @@
 void TableView::OnBlur() {
   SchedulePaintForSelection();
 }
 
 void TableView::NumRowsChanged() {
   SortItemsAndUpdateMapping();
   PreferredSizeChanged();
   SchedulePaint();
 }
 
-void TableView::SetSortDescriptors(const SortDescriptors& sort_descriptors) {
-  sort_descriptors_ = sort_descriptors;
-  SortItemsAndUpdateMapping();
-  if (header_)
-    header_->SchedulePaint();
-}
-
 void TableView::SortItemsAndUpdateMapping() {
   if (!is_sorted()) {
     view_to_model_.clear();
     model_to_view_.clear();
   } else {
     const int row_count = RowCount();
     view_to_model_.resize(row_count);
     model_to_view_.resize(row_count);
     for (int i = 0; i < row_count; ++i)
       view_to_model_[i] = i;
@@ skipping 292 matching lines @@
   if (tooltip)
     *tooltip = text;
   if (tooltip_origin) {
     tooltip_origin->SetPoint(cell_bounds.x(),
                              cell_bounds.y() + kTextVerticalPadding);
   }
   return true;
 }
 
 }  // namespace views