Issue 214603010: Relanding user gesture fix for external protocol handlers after revert.

Issue 214603010: Relanding user gesture fix for external protocol handlers after revert. (Closed)

Created:
6 years, 8 months ago by meacer

Modified:
6 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit), Jói, boliu, Peter Kasting, mmenke, not at google - send to devlin

CC:
chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, tfarina, jam, gavinp+prer_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, James Su, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Relanding user gesture fix for external protocol handlers after revert. The original CL that broke the build: https://codereview.chromium.org/131783012/ BUG=173557 TBR=pkasting@chromium.org,joi@chromium.org,kalman@chromium.org,jochen@chromium.org,mmenke@chromium.org,boliu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261316

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -142 lines)			Patch
M	android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	apps/shell/browser/shell_extensions_browser_client.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	apps/shell/browser/shell_extensions_browser_client.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_input.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/active_tab_permission_granter.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/chrome_extensions_browser_client.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/chrome_extensions_browser_client.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/external_protocol/external_protocol_handler.h	View	3 chunks	+8 lines, -20 lines	0 comments	Download
M	chrome/browser/external_protocol/external_protocol_handler.cc	View	6 chunks	+16 lines, -24 lines	0 comments	Download
M	chrome/browser/external_protocol/external_protocol_handler_unittest.cc	View	3 chunks	+3 lines, -7 lines	0 comments	Download
D	chrome/browser/external_protocol/external_protocol_observer.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	chrome/browser/external_protocol/external_protocol_observer.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	chrome/browser/prerender/prerender_browsertest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc	View	4 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/tab_helpers.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	content/browser/loader/resource_dispatcher_host_impl.cc	View	1 chunk	+9 lines, -2 lines	0 comments	Download
M	content/public/browser/resource_dispatcher_host_delegate.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	content/public/browser/resource_dispatcher_host_delegate.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	extensions/browser/extension_function_dispatcher.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	extensions/browser/extensions_browser_client.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	extensions/browser/test_extensions_browser_client.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	extensions/browser/test_extensions_browser_client.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download