Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 214603005: Remove explicit Skia save flags. (Closed)

Created:
6 years, 9 months ago by f(malita)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove explicit Skia save flags. SaveFlags are being deprecated in Skia. This CL updates the call sites to use defaults (kMatrixClip_SaveFlag for save(), kARGB_ClipLayer_SaveFlag for saveLayer()). R=piman@chromium.org, reed@google.com, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/renderer/skia_benchmarking_extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
f(malita)
6 years, 9 months ago (2014-03-27 15:56:43 UTC) #1
reed1
lgtm for skia considerations
6 years, 9 months ago (2014-03-27 15:58:26 UTC) #2
sky
LGTM
6 years, 9 months ago (2014-03-27 16:04:20 UTC) #3
piman
lgtm
6 years, 9 months ago (2014-03-27 17:54:58 UTC) #4
fmalita_google_do_not_use
The CQ bit was checked by fmalita@google.com
6 years, 9 months ago (2014-03-27 17:57:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/214603005/1
6 years, 9 months ago (2014-03-27 17:58:33 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:00:47 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 23:00:47 UTC) #8
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 9 months ago (2014-03-28 12:42:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/214603005/1
6 years, 9 months ago (2014-03-28 12:43:09 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 13:16:43 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290280
6 years, 9 months ago (2014-03-28 13:16:44 UTC) #12
f(malita)
6 years, 9 months ago (2014-03-28 13:25:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 manually as r260115 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698