Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 214603003: Use a global variable in the test to avoid flakiness in the Mac port. (Closed)

Created:
6 years, 9 months ago by mario.prada
Modified:
6 years, 9 months ago
Reviewers:
tkent, eae
CC:
blink-reviews, keishi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use a global variable in the test to avoid flakiness in the Mac port. Apparently, runOnOpenPopup1() function was being called again after invoking iframe.contentWindow.location.reload(), right between finishing the execution of runOnIFrameLoad() and finishJSTest(), in the Mac platform. This patch avoids the issue by using one global flag to early return in that function when the iframe has already been reloaded. BUG=357176 R=tkent@chromium.org,eae@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-reset-value-after-reload.html View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mario.prada
6 years, 9 months ago (2014-03-27 15:22:53 UTC) #1
eae
LGTM
6 years, 9 months ago (2014-03-27 16:45:30 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-27 16:45:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mario.prada@samsung.com/214603003/1
6 years, 9 months ago (2014-03-27 16:45:40 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 17:11:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 17:11:13 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-27 22:44:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mario.prada@samsung.com/214603003/1
6 years, 9 months ago (2014-03-27 22:45:02 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 23:54:00 UTC) #9
Message was sent while issue was closed.
Change committed as 170226

Powered by Google App Engine
This is Rietveld 408576698