Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 214603002: CSS Animations: Generate a single player for each keyframe animation. (Closed)

Created:
6 years, 9 months ago by dstockwell
Modified:
6 years, 9 months ago
Reviewers:
Eric Willigers
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

CSS Animations: Generate a single player for each keyframe animation. Logic to split keyframe animations into multiple players was required before Web Animations supported per-keyframe easings. CSS Animations were updated to use per-keyframe easings in r169119[1], but this logic remained. [1] https://src.chromium.org/viewvc/blink?view=rev&revision=169119 BUG=346590 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170302

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -133 lines) Patch
M Source/core/animation/css/CSSAnimations.h View 6 chunks +14 lines, -16 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 10 chunks +26 lines, -117 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dstockwell
6 years, 9 months ago (2014-03-27 11:54:10 UTC) #1
Eric Willigers
lgtm
6 years, 9 months ago (2014-03-27 23:15:34 UTC) #2
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 08:37:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/214603002/20001
6 years, 9 months ago (2014-03-28 08:37:24 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 09:37:22 UTC) #5
Message was sent while issue was closed.
Change committed as 170302

Powered by Google App Engine
This is Rietveld 408576698