Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: components/precache/content/precache_manager.cc

Issue 2146023003: Add UMA Precache.Freshness.Prefetch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added missing includes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/precache/content/precache_manager.cc
diff --git a/components/precache/content/precache_manager.cc b/components/precache/content/precache_manager.cc
index 303d7900660c089774bf54115f78e4b221167e34..8e6e1a6d568d578c36a2e39f09664b809492d506 100644
--- a/components/precache/content/precache_manager.cc
+++ b/components/precache/content/precache_manager.cc
@@ -224,12 +224,12 @@ void PrecacheManager::UpdatePrecacheMetricsAndState(
const GURL& referrer,
const base::TimeDelta& latency,
const base::Time& fetch_time,
+ const net::HttpResponseInfo& info,
int64_t size,
- bool was_cached,
bool is_user_traffic) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- RecordStatsForFetch(url, referrer, latency, fetch_time, size, was_cached);
+ RecordStatsForFetch(url, referrer, latency, fetch_time, info, size);
if (is_user_traffic && IsPrecaching())
CancelPrecaching();
}
@@ -238,8 +238,8 @@ void PrecacheManager::RecordStatsForFetch(const GURL& url,
const GURL& referrer,
const base::TimeDelta& latency,
const base::Time& fetch_time,
- int64_t size,
- bool was_cached) {
+ const net::HttpResponseInfo& info,
+ int64_t size) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (size == 0 || url.is_empty() || !url.SchemeIsHTTPOrHTTPS()) {
@@ -251,17 +251,16 @@ void PrecacheManager::RecordStatsForFetch(const GURL& url,
return;
history_service_->HostRankIfAvailable(
- referrer,
- base::Bind(&PrecacheManager::RecordStatsForFetchInternal, AsWeakPtr(),
- url, latency, fetch_time, size, was_cached));
+ referrer, base::Bind(&PrecacheManager::RecordStatsForFetchInternal,
+ AsWeakPtr(), url, latency, fetch_time, info, size));
}
void PrecacheManager::RecordStatsForFetchInternal(
const GURL& url,
const base::TimeDelta& latency,
const base::Time& fetch_time,
+ const net::HttpResponseInfo& info,
int64_t size,
- bool was_cached,
int host_rank) {
if (is_precaching_) {
// Assume that precache is responsible for all requests made while
@@ -273,7 +272,7 @@ void PrecacheManager::RecordStatsForFetchInternal(
BrowserThread::DB, FROM_HERE,
base::Bind(&PrecacheDatabase::RecordURLPrefetch,
base::Unretained(precache_database_.get()), url, latency,
- fetch_time, size, was_cached));
+ fetch_time, info, size));
} else {
bool is_connection_cellular =
net::NetworkChangeNotifier::IsConnectionCellular(
@@ -283,8 +282,7 @@ void PrecacheManager::RecordStatsForFetchInternal(
BrowserThread::DB, FROM_HERE,
base::Bind(&PrecacheDatabase::RecordURLNonPrefetch,
base::Unretained(precache_database_.get()), url, latency,
- fetch_time, size, was_cached, host_rank,
- is_connection_cellular));
+ fetch_time, info, size, host_rank, is_connection_cellular));
}
}
« no previous file with comments | « components/precache/content/precache_manager.h ('k') | components/precache/content/precache_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698