Add UMA Precache.Freshness.Prefetch

components/precache/content/precache_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PRECACHE_CONTENT_PRECACHE_MANAGER_H_
 #define COMPONENTS_PRECACHE_CONTENT_PRECACHE_MANAGER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <list>
 #include <memory>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "components/history/core/browser/history_types.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/precache/core/precache_fetcher.h"
+#include "net/http/http_response_info.h"

[bengr, 2016/07/21 00:03:27]

Forward declare instead.

[jamartin, 2016/07/25 23:23:07]

Done.

Nice! This should get rid of the change in DEPS and thus one reviewer less :-)

 #include "url/gurl.h"
 
 namespace base {
 class FilePath;
 class Time;
 class TimeDelta;
 }
 
 namespace content {
 class BrowserContext;
@@ skipping 67 matching lines @@
   // database. Does not wait for completion of this task.
   void ClearHistory();
 
   // Update precache about an URL being fetched. Metrics related to precache are
   // updated and any ongoing precache will be cancelled if this is an user
   // initiated request. Should be called on UI thread.
   void UpdatePrecacheMetricsAndState(const GURL& url,
                                      const GURL& referrer,
                                      const base::TimeDelta& latency,
                                      const base::Time& fetch_time,
+                                     const net::HttpResponseInfo& info,
                                      int64_t size,
-                                     bool was_cached,
                                      bool is_user_traffic);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(PrecacheManagerTest, DeleteExpiredPrecacheHistory);
   FRIEND_TEST_ALL_PREFIXES(PrecacheManagerTest,
                            RecordStatsForFetchDuringPrecaching);
   FRIEND_TEST_ALL_PREFIXES(PrecacheManagerTest, RecordStatsForFetchHTTP);
   FRIEND_TEST_ALL_PREFIXES(PrecacheManagerTest, RecordStatsForFetchHTTPS);
   FRIEND_TEST_ALL_PREFIXES(PrecacheManagerTest, RecordStatsForFetchInTopHosts);
   FRIEND_TEST_ALL_PREFIXES(PrecacheManagerTest,
@@ skipping 29 matching lines @@
   void OnHostsReceivedThenDone(const history::TopHostsList& host_counts);
 
   // Returns true if precaching is allowed for the browser context.
   AllowedType PrecachingAllowed() const;
 
   // Update precache-related metrics in response to a URL being fetched.
   void RecordStatsForFetch(const GURL& url,
                            const GURL& referrer,
                            const base::TimeDelta& latency,
                            const base::Time& fetch_time,
-                           int64_t size,
-                           bool was_cached);
+                           const net::HttpResponseInfo& info,
+                           int64_t size);
 
   // Update precache-related metrics in response to a URL being fetched. Called
   // by RecordStatsForFetch() by way of an asynchronous HistoryService callback.
   void RecordStatsForFetchInternal(const GURL& url,
                                    const base::TimeDelta& latency,
                                    const base::Time& fetch_time,
+                                   const net::HttpResponseInfo& info,
                                    int64_t size,
-                                   bool was_cached,
                                    int host_rank);
 
   // The browser context that owns this PrecacheManager.
   content::BrowserContext* const browser_context_;
 
   // The sync service corresponding to the browser context. Used to determine
   // whether precache can run. May be null.
   const sync_driver::SyncService* const sync_service_;
 
   // The history service corresponding to the browser context. Used to determine
@@ skipping 17 matching lines @@
 
   // Work that hasn't yet finished.
   std::unique_ptr<PrecacheUnfinishedWork> unfinished_work_;
 
   DISALLOW_COPY_AND_ASSIGN(PrecacheManager);
 };
 
 }  // namespace precache
 
 #endif  // COMPONENTS_PRECACHE_CONTENT_PRECACHE_MANAGER_H_