Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Issue 2146023002: Revert of Roll buildtools aa47d9773d..924d50ecae (Closed)

Created:
4 years, 5 months ago by Reid Kleckner
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll buildtools aa47d9773d..924d50ecae (patchset #1 id:1 of https://codereview.chromium.org/2138013004/ ) Reason for revert: Broke uses of 'clang=1 llvm_force_head_revision=1' on clang tot waterfall: https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot Original issue's description: > Roll buildtools aa47d9773d..924d50ecae > > In order to roll GN b9999d69a9..4828a631a7 (r403866:r404813) and pick up > the following changes: > > 5662a80 GN: Don't define argument overrides globally > 45a841b Suggest `gn help` for internally set arguments. > bf462ea [GN docs] Add missing word in gn actions help string > 8273381 Fix typos in GN error message > > TBR=dpranke@chromium.org > > Committed: https://crrev.com/932788e86f1f59cdff52df8ae78784af6f8a17e6 > Cr-Commit-Position: refs/heads/master@{#405054} TBR=dpranke@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8a326e54dc5d1c8b0c3c0aa8f15ceb48880cb81c Cr-Commit-Position: refs/heads/master@{#405169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Reid Kleckner
Created Revert of Roll buildtools aa47d9773d..924d50ecae
4 years, 5 months ago (2016-07-13 15:57:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146023002/1
4 years, 5 months ago (2016-07-13 15:58:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 15:59:34 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8a326e54dc5d1c8b0c3c0aa8f15ceb48880cb81c Cr-Commit-Position: refs/heads/master@{#405169}
4 years, 5 months ago (2016-07-13 16:01:23 UTC) #7
Dirk Pranke
4 years, 5 months ago (2016-07-13 16:32:09 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698