Rename adjustPointerLockElement

Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function not specific to pointer lock.

No functional change.

BUG=622585
Committed: https://crrev.com/d79429192ab8246c6f88a79b076e7ff1ddcba45c
Cr-Commit-Position: refs/heads/master@{#405729}

[kochi, 2016-07-14 10:15:02]

Description was changed from

==========
Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function to align more with what it does.

BUG=622585
==========

to

==========
Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function to align more with what it does.

No functional change.

BUG=622585
==========

[kochi, 2016-07-14 10:15:02]

kochi@chromium.org changed reviewers:
+ hayato@chromium.org

[kochi, 2016-07-14 10:15:09]

PTAL

[hayato, 2016-07-15 00:29:03]

retargetElementIfInSameTreeScope does not reflect the behavior, I think.

That would impress us that, "At first, we check whether the element is in the
same treescope or not. If so, we try to retarget it".

Could you have better name?
Sorry that I do not have a proposal.

[kochi, 2016-07-15 02:26:28]

On 2016/07/15 00:29:03, hayato wrote:
> retargetElementIfInSameTreeScope does not reflect the behavior, I think.
> 
> That would impress us that, "At first, we check whether the element is in the
> same treescope or not. If so, we try to retarget it".
> 
> Could you have better name?
> Sorry that I do not have a proposal.

How about simply "TreeScope::adjustedElement(Element*)" then?
We already have adjustedFocusedElement().

I'll add some comment to the method what it does.

[hayato, 2016-07-15 04:58:10]

On 2016/07/15 at 02:26:28, kochi wrote:
> On 2016/07/15 00:29:03, hayato wrote:
> > retargetElementIfInSameTreeScope does not reflect the behavior, I think.
> > 
> > That would impress us that, "At first, we check whether the element is in
the
> > same treescope or not. If so, we try to retarget it".
> > 
> > Could you have better name?
> > Sorry that I do not have a proposal.
> 
> How about simply "TreeScope::adjustedElement(Element*)" then?
> We already have adjustedFocusedElement().
> 
> I'll add some comment to the method what it does.

Okay. I do not have any better idea.

Eventually, we should *upstream* this name to DOM Standard. So we should
consider this again later.

[hayato, 2016-07-15 04:58:17]

lgtm

[kochi, 2016-07-15 05:35:11]

Updated the function name and comments.
PTAL.

https://codereview.chromium.org/2146013003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/TreeScope.cpp (right):

https://codereview.chromium.org/2146013003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/TreeScope.cpp:395: // find a shadow host that
is in the same TreeScope as |scope|.
(although I wrote this comment) it seems weird as there is no |scope|
variable, and basically this says the logic below literally, which is
redundant.

[kochi, 2016-07-15 05:35:43]

Description was changed from

==========
Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function to align more with what it does.

No functional change.

BUG=622585
==========

to

==========
Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function not specific to pointer lock.

No functional change.

BUG=622585
==========

[hayato, 2016-07-15 06:24:40]

lgtm

https://codereview.chromium.org/2146013003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h (right):

https://codereview.chromium.org/2146013003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h:64: return
document.adjustedElement(*target);
Nit: Can we rename this `adjustedElement` to `adjustElement`?

[kochi, 2016-07-15 06:34:17]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2016-07-15 06:34:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kochi, 2016-07-15 06:40:09]

https://codereview.chromium.org/2146013003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h (right):

https://codereview.chromium.org/2146013003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h:64: return
document.adjustedElement(*target);
On 2016/07/15 06:24:40, hayato wrote:
> Nit: Can we rename this `adjustedElement` to `adjustElement`?

returns an adjusted element of *target (for document), so I think this is okay.

[commit-bot: I haz the power, 2016-07-15 09:14:06]

Description was changed from

==========
Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function not specific to pointer lock.

No functional change.

BUG=622585
==========

to

==========
Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function not specific to pointer lock.

No functional change.

BUG=622585
==========

[commit-bot: I haz the power, 2016-07-15 09:14:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 09:15:36]

Description was changed from

==========
Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function not specific to pointer lock.

No functional change.

BUG=622585
==========

to

==========
Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function not specific to pointer lock.

No functional change.

BUG=622585

Committed: https://crrev.com/d79429192ab8246c6f88a79b076e7ff1ddcba45c
Cr-Commit-Position: refs/heads/master@{#405729}
==========

[commit-bot: I haz the power, 2016-07-15 09:15:38]

Patchset 2 (id:??) landed as
https://crrev.com/d79429192ab8246c6f88a79b076e7ff1ddcba45c
Cr-Commit-Position: refs/heads/master@{#405729}