chrome/browser/media/router/mojo/media_router_mojo_metrics.cc - Issue 2145983003: [Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_metrics.cc

Issue 2145983003: [Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo in media_router_bindings.js Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/mojo/media_router_mojo_metrics.h ('k') | chrome/browser/media/router/mojo/media_router_mojo_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/mojo/media_router_mojo_metrics.cc

diff --git a/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc b/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc

index 6937f32ad36b9ff8b637e0718bce95347e4a8a7e..5c9b291977ed9c17c1fa8e36516bc55dc9a78c06 100644

--- a/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc

+++ b/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc

@@ -50,6 +50,15 @@ void MediaRouterMojoMetrics::RecordMediaRouteProviderWakeup(

}

// static

+void MediaRouterMojoMetrics::RecordMediaRouteProviderTerminateRoute(

+ RouteRequestResult::ResultCode result_code) {

+ DCHECK_LT(result_code, RouteRequestResult::ResultCode::TOTAL_COUNT);

+ UMA_HISTOGRAM_ENUMERATION(

+ "MediaRouter.Provider.TerminateRoute.Result", result_code,

+ RouteRequestResult::ResultCode::TOTAL_COUNT);

+// static

MediaRouteProviderVersion MediaRouterMojoMetrics::GetMediaRouteProviderVersion(

const base::Version& extension_version,

const base::Version& browser_version) {