Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl.cc

Issue 2145983003: [Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo in media_router_bindings.js Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router_mojo_impl.cc
diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
index 49718c8bbc7e6e1195545ad88cd622d5586f1501..80885d0ae35971794abe8ac9a633c471073d309a 100644
--- a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
@@ -688,7 +688,10 @@ void MediaRouterMojoImpl::DoConnectRouteByRouteId(
void MediaRouterMojoImpl::DoTerminateRoute(const MediaRoute::Id& route_id) {
DVLOG_WITH_INSTANCE(1) << "DoTerminateRoute " << route_id;
- media_route_provider_->TerminateRoute(route_id);
+ media_route_provider_->TerminateRoute(
+ route_id,
+ base::Bind(&MediaRouterMojoImpl::OnTerminateRouteResult,
+ base::Unretained(this), route_id));
}
void MediaRouterMojoImpl::DoDetachRoute(const MediaRoute::Id& route_id) {
@@ -808,6 +811,18 @@ void MediaRouterMojoImpl::OnPresentationConnectionClosed(
message);
}
+void MediaRouterMojoImpl::OnTerminateRouteResult(
+ const MediaRoute::Id& route_id,
+ mojo::String error_text,
+ interfaces::RouteRequestResultCode result_code) {
+ if (result_code != interfaces::RouteRequestResultCode::OK) {
+ LOG(WARNING) << "Failed to terminate route " << route_id <<
+ ": result_code = " << result_code << ", " << error_text;
+ }
+ MediaRouterMojoMetrics::RecordMediaRouteProviderTerminateRoute(
+ mojo::RouteRequestResultCodeFromMojo(result_code));
+}
+
void MediaRouterMojoImpl::DoStartObservingMediaSinks(
const MediaSource::Id& source_id) {
DVLOG_WITH_INSTANCE(1) << "DoStartObservingMediaSinks: " << source_id;

Powered by Google App Engine
This is Rietveld 408576698