Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2221)

Unified Diff: chrome/browser/media/router/mojo/media_router.mojom

Issue 2145983003: [Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo in media_router_bindings.js Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/router/mojo/media_router_mojo_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/mojo/media_router.mojom
diff --git a/chrome/browser/media/router/mojo/media_router.mojom b/chrome/browser/media/router/mojo/media_router.mojom
index bbf4a3b5c53ee0779987f7cc8c78238c84c620cf..4fcdbdf70d530c1006d7e72b75f3005c576c2820 100644
--- a/chrome/browser/media/router/mojo/media_router.mojom
+++ b/chrome/browser/media/router/mojo/media_router.mojom
@@ -122,13 +122,20 @@ struct SinkSearchCriteria {
string domain;
};
-// Maps to a ResultCode value in route_request_result.h
-// The enum defined here is a subset of those defined in route_request_result.h.
+// Keep in sync with:
+// - RouteRequestResult::ResultCode in route_request_result.h
+// - MediaRouteProviderResult enum in tools/metrics/histograms.xml.
+// - mr.RouteRequestResultCode in route_request_error.js
enum RouteRequestResultCode {
UNKNOWN_ERROR,
OK,
TIMED_OUT,
- ROUTE_NOT_FOUND
+ ROUTE_NOT_FOUND,
+ SINK_NOT_FOUND,
+ INVALID_ORIGIN,
+ OFF_THE_RECORD_MISMATCH,
+ NO_SUPPORTED_PROVIDER
+// New values must be added here.
};
// Modeled after the MediaRouter interface defined in
@@ -229,8 +236,12 @@ interface MediaRouteProvider {
string? error_text,
RouteRequestResultCode result_code);
- // Terminates the route specified by |route_id|.
- TerminateRoute(string route_id);
+ // Terminates the route specified by |route_id|. If the route was terminated
+ // successfully, |result_code| is set to OK and |error_text| is null.
+ // Otherwise, |result_code| is an error code and |error_text| describes the
+ // error.
+ TerminateRoute(string route_id) =>
+ (string? error_text, RouteRequestResultCode result_code);
// Sends |message| via the media route |media_route_id|.
// If the operation was successful, |sent| is true; otherwise it is false.
« no previous file with comments | « no previous file | chrome/browser/media/router/mojo/media_router_mojo_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698