chrome/browser/media/router/route_request_result.h - Issue 2145983003: [Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/route_request_result.h

Issue 2145983003: [Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix line too long Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/mojo/media_router_type_converters.cc ('k') | extensions/renderer/resources/media_router_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/route_request_result.h

diff --git a/chrome/browser/media/router/route_request_result.h b/chrome/browser/media/router/route_request_result.h

index 0a473a41e19ca79b204048a25a03b4ed387edd7e..3049f3aa837972bd64db5bd9039766d8b877a9f0 100644

--- a/chrome/browser/media/router/route_request_result.h

+++ b/chrome/browser/media/router/route_request_result.h

@@ -30,13 +30,22 @@ class MediaRoute;

// |result_code|: A value from RouteRequestResult describing the error.

class RouteRequestResult {

public:

+ // Keep in sync with:

+ // - RouteRequestResultCode in media_router.mojom

+ // - MediaRouteProviderResult enum in tools/metrics/histograms.xml

Ilya Sherman 2016/07/18 22:56:57 Please also document that this enum should be trea

+ // - mr.RouteRequestResultCode in route_request_error.js

enum ResultCode {

- UNKNOWN_ERROR,

- OK,

- TIMED_OUT,

- ROUTE_NOT_FOUND,

- INVALID_ORIGIN,

- OFF_THE_RECORD_MISMATCH

+ UNKNOWN_ERROR = 0,

+ OK = 1,

+ TIMED_OUT = 2,

+ ROUTE_NOT_FOUND = 3,

+ SINK_NOT_FOUND = 4,

+ INVALID_ORIGIN = 5,

+ OFF_THE_RECORD_MISMATCH = 6,

+ NO_SUPPORTED_PROVIDER = 7,

+ // This is the total number of values.

+ TOTAL_COUNT = 8

};

static std::unique_ptr<RouteRequestResult> FromSuccess(