Enable False Start for OpenSSL.

Enable False Start for OpenSSL.

BUG=354132
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265685

[davidben, 2014-04-11 18:20:17]

This depends on https://codereview.chromium.org/208293002/ but sending it out
now because a question occurred to me about the ifdef business.

https://codereview.chromium.org/214593009/diff/60001/net/socket/ssl_client_so...
File net/socket/ssl_client_socket_openssl.cc (right):

https://codereview.chromium.org/214593009/diff/60001/net/socket/ssl_client_so...
net/socket/ssl_client_socket_openssl.cc:858: #if
defined(SSL_MODE_HANDSHAKE_CUTTHROUGH)
How much do we need these ifdefs anyway? Is this because of android_webview? In
that case, perhaps we should have added further ifdefs or defines in OpenSSL so
that Android doesn't get an older False Start enabled...

[Ryan Sleevi, 2014-04-11 19:15:49]

On 2014/04/11 18:20:17, David Benjamin wrote:
> This depends on https://codereview.chromium.org/208293002/ but sending it out
> now because a question occurred to me about the ifdef business.
> 
>
https://codereview.chromium.org/214593009/diff/60001/net/socket/ssl_client_so...
> File net/socket/ssl_client_socket_openssl.cc (right):
> 
>
https://codereview.chromium.org/214593009/diff/60001/net/socket/ssl_client_so...
> net/socket/ssl_client_socket_openssl.cc:858: #if
> defined(SSL_MODE_HANDSHAKE_CUTTHROUGH)
> How much do we need these ifdefs anyway? Is this because of android_webview?
In
> that case, perhaps we should have added further ifdefs or defines in OpenSSL
so
> that Android doesn't get an older False Start enabled...

Yes, it's for webview that builds against Android system. However, we only need
to worry about Android (current + next) with respect to android_webview, so we
could probably remove these. Let's not do it in this CL.

[davidben, 2014-04-11 19:18:16]

On 2014/04/11 19:15:49, Ryan Sleevi wrote:
> On 2014/04/11 18:20:17, David Benjamin wrote:
> > This depends on https://codereview.chromium.org/208293002/ but sending it
out
> > now because a question occurred to me about the ifdef business.
> > 
> >
>
https://codereview.chromium.org/214593009/diff/60001/net/socket/ssl_client_so...
> > File net/socket/ssl_client_socket_openssl.cc (right):
> > 
> >
>
https://codereview.chromium.org/214593009/diff/60001/net/socket/ssl_client_so...
> > net/socket/ssl_client_socket_openssl.cc:858: #if
> > defined(SSL_MODE_HANDSHAKE_CUTTHROUGH)
> > How much do we need these ifdefs anyway? Is this because of android_webview?
> In
> > that case, perhaps we should have added further ifdefs or defines in OpenSSL
> so
> > that Android doesn't get an older False Start enabled...
> 
> Yes, it's for webview that builds against Android system. However, we only
need
> to worry about Android (current + next) with respect to android_webview, so we
> could probably remove these. Let's not do it in this CL.

Hrm. We'd need to get that OpenSSL patch into Android current and next then,
wouldn't we? That or arrange so that False Start isn't enabled there.

[davidben, 2014-04-17 19:38:39]

Rebased and added ifdef for webview. False Start tests look to be sticking now!

[davidben, 2014-04-17 19:53:25]

Aaaand ifdefs punted. Sounds like webview was never building with system openssl
anyway.

[Ryan Sleevi, 2014-04-17 20:02:44]

lgtm

[davidben, 2014-04-17 20:16:38]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-04-17 20:16:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/214593009/110001

[davidben, 2014-04-17 20:53:52]

The CQ bit was unchecked by davidben@chromium.org

[davidben, 2014-04-17 20:55:19]

On 2014/04/17 20:16:59, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/davidben@chromium.org/214593009/110001

Removing from CQ pending sorting out
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...
failure. Patch set 6, but patch set 7 changes shouldn't affect it I hope?
Perhaps Android runs tests funny.

[davidben, 2014-04-17 22:13:47]

On 2014/04/17 20:55:19, David Benjamin wrote:
> On 2014/04/17 20:16:59, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >
https://chromium-status.appspot.com/cq/davidben@chromium.org/214593009/110001
> 
> Removing from CQ pending sorting out
>
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...
> failure. Patch set 6, but patch set 7 changes shouldn't affect it I hope?
> Perhaps Android runs tests funny.

https://codereview.chromium.org/241423003/

[davidben, 2014-04-23 15:26:31]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-04-23 15:26:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/214593009/110001

[commit-bot: I haz the power, 2014-04-23 18:06:25]

Change committed as 265685