Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2145923002: [turbofan] Properly optimize JSToBoolean with Number inputs. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly optimize JSToBoolean with Number inputs. For JSToBoolean with Number inputs we still called out to the ToBooleanStub, even though we easily handle them inline nowadays. R=jarin@chromium.org Committed: https://crrev.com/3861e513228926cbb99aa2319b4003ea2ad08c58 Cr-Commit-Position: refs/heads/master@{#37699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-13 07:24:19 UTC) #1
Benedikt Meurer
Hey Jaro, Another easy one for Kraken. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-13 07:29:51 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-13 07:55:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145923002/1
4 years, 5 months ago (2016-07-13 07:55:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 07:57:31 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 07:57:33 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:00:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3861e513228926cbb99aa2319b4003ea2ad08c58
Cr-Commit-Position: refs/heads/master@{#37699}

Powered by Google App Engine
This is Rietveld 408576698