third_party/WebKit/Source/core/layout/LayoutTextControl.h - Issue 2145903002: Add heuristic to LayoutTextControl::hasValidAvgCharWidth()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextControl.h

Issue 2145903002: Add heuristic to LayoutTextControl::hasValidAvgCharWidth() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTextControl.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutTextControl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTextControl.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutTextControl.h b/third_party/WebKit/Source/core/layout/LayoutTextControl.h

index 221d2d7d95d8f2df89b5062297e57b16b741cde0..002c6cd572c40dc06f2c27e25953867566e7c255 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTextControl.h

+++ b/third_party/WebKit/Source/core/layout/LayoutTextControl.h

@@ -58,7 +58,7 @@ protected:

float scaleEmToUnits(int x) const;

- static bool hasValidAvgCharWidth(const AtomicString& family);

+ static bool hasValidAvgCharWidth(const SimpleFontData*, const AtomicString& family);

virtual float getAvgCharWidth(const AtomicString& family) const;

virtual LayoutUnit preferredContentLogicalWidth(float charWidth) const = 0;

virtual LayoutUnit computeControlLogicalHeight(LayoutUnit lineHeight, LayoutUnit nonContentHeight) const = 0;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTextControl.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutTextControl.cpp » ('J')