Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2145893003: Remove video-test.js dependency from video-autoplay-experiment-just-once.html (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove video-test.js dependency from video-autoplay-experiment-just-once.html BUG=588956 Committed: https://crrev.com/9ebd080e96d27bde53cc1e8ffd8340948b251d21 Cr-Commit-Position: refs/heads/master@{#405200}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove video-test.js dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html View 1 4 chunks +22 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once-expected.txt View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-13 14:44:28 UTC) #3
fs
https://codereview.chromium.org/2145893003/diff/1/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html File third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html (right): https://codereview.chromium.org/2145893003/diff/1/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html#newcode3 third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html:3: <script src=video-test.js></script> I think eliminating video-test.js stuff would still ...
4 years, 5 months ago (2016-07-13 14:46:34 UTC) #4
Srirama
https://codereview.chromium.org/2145893003/diff/1/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html File third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html (right): https://codereview.chromium.org/2145893003/diff/1/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html#newcode3 third_party/WebKit/LayoutTests/media/video-autoplay-experiment-just-once.html:3: <script src=video-test.js></script> On 2016/07/13 14:46:34, fs (ooo to July ...
4 years, 5 months ago (2016-07-13 15:35:29 UTC) #6
fs
lgtm
4 years, 5 months ago (2016-07-13 15:53:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145893003/20001
4 years, 5 months ago (2016-07-13 15:56:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 17:06:51 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:08:05 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9ebd080e96d27bde53cc1e8ffd8340948b251d21
Cr-Commit-Position: refs/heads/master@{#405200}

Powered by Google App Engine
This is Rietveld 408576698