Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2145873003: Initialize all parameters for MockDeviceMotion interface (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Mike West
CC:
chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize all parameters for MockDeviceMotion interface BUG=623168 R=mkwst@chromium.org Committed: https://crrev.com/fb093a52259d93bc5efd77776927afc18ac57277 Cr-Commit-Position: refs/heads/master@{#405115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M components/test_runner/test_runner.cc View 1 chunk +29 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-13 09:33:44 UTC) #1
Mike West
LGTM.
4 years, 5 months ago (2016-07-13 09:44:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145873003/1
4 years, 5 months ago (2016-07-13 09:45:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 10:42:20 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 10:42:30 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 10:43:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb093a52259d93bc5efd77776927afc18ac57277
Cr-Commit-Position: refs/heads/master@{#405115}

Powered by Google App Engine
This is Rietveld 408576698