Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/android/data_usage/data_use_tab_model.h

Issue 2145863002: Separate data use reporting logic in ExternalDataUseObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/external_data_use_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_TAB_MODEL_H_ 5 #ifndef CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_TAB_MODEL_H_
6 #define CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_TAB_MODEL_H_ 6 #define CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_TAB_MODEL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 // |tab_id|. Protected for testing. 214 // |tab_id|. Protected for testing.
215 void NotifyObserversOfTrackingEnding(SessionID::id_type tab_id); 215 void NotifyObserversOfTrackingEnding(SessionID::id_type tab_id);
216 216
217 // Notifies the observers that DataUseTabModel is ready to process navigation 217 // Notifies the observers that DataUseTabModel is ready to process navigation
218 // events. 218 // events.
219 void NotifyObserversOfDataUseTabModelReady(); 219 void NotifyObserversOfDataUseTabModelReady();
220 220
221 private: 221 private:
222 friend class DataUseTabModelTest; 222 friend class DataUseTabModelTest;
223 friend class ExternalDataUseObserverTest; 223 friend class ExternalDataUseObserverTest;
224 friend class ExternalDataUseReporterTest;
224 friend class TabDataUseEntryTest; 225 friend class TabDataUseEntryTest;
225 friend class TestDataUseTabModel; 226 friend class TestDataUseTabModel;
226 FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, 227 FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest,
227 CompactTabEntriesWithinMaxLimit); 228 CompactTabEntriesWithinMaxLimit);
228 FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, 229 FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest,
229 ExpiredInactiveTabEntryRemovaltimeHistogram); 230 ExpiredInactiveTabEntryRemovaltimeHistogram);
230 FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, 231 FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest,
231 MatchingRuleClearedOnControlAppUninstall); 232 MatchingRuleClearedOnControlAppUninstall);
232 FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest, 233 FRIEND_TEST_ALL_PREFIXES(DataUseTabModelTest,
233 MultipleObserverMultipleStartEndEvents); 234 MultipleObserverMultipleStartEndEvents);
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 base::WeakPtrFactory<DataUseTabModel> weak_factory_; 320 base::WeakPtrFactory<DataUseTabModel> weak_factory_;
320 321
321 DISALLOW_COPY_AND_ASSIGN(DataUseTabModel); 322 DISALLOW_COPY_AND_ASSIGN(DataUseTabModel);
322 }; 323 };
323 324
324 } // namespace android 325 } // namespace android
325 326
326 } // namespace chrome 327 } // namespace chrome
327 328
328 #endif // CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_TAB_MODEL_H_ 329 #endif // CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_TAB_MODEL_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/external_data_use_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698