Remove step that copies llvm-symbolizer to the root build dir.

Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

Clusterfuzz used to need this, but it stopped needing it in
https://codereview.chromium.org/2394163006/

No intentional behavior change.

BUG=none, vaguely related to 430156 and 495204

Committed: https://crrev.com/eeaccfd53c4d582d39ec7e30f19d8e4db8b4ee49
Cr-Commit-Position: refs/heads/master@{#436986}

[Nico, 2016-07-15 14:45:52]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 14:46:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 17:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 17:03:43]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-07-15 17:05:55]

thakis@chromium.org changed reviewers:
+ inferno@chromium.org

[Nico, 2016-07-15 17:05:56]

inferno, lkgr doesn't need this either, does it?

[inferno, 2016-07-15 17:16:00]

On 2016/07/15 17:05:56, Nico wrote:
> inferno, lkgr doesn't need this either, does it?

This is needed for lkgr archived builds, we need to copy llvm-symbolizer to root
of that archive so that clusterfuzz bots can use latest version.

[Nico, 2016-07-15 17:17:43]

On 2016/07/15 17:16:00, inferno wrote:
> On 2016/07/15 17:05:56, Nico wrote:
> > inferno, lkgr doesn't need this either, does it?
> 
> This is needed for lkgr archived builds, we need to copy llvm-symbolizer to
root
> of that archive so that clusterfuzz bots can use latest version.

Can't the clusterfuzz bots use the one in
third_party/llvm-build/Release+Asserts/bin instead? That's what all the other
places do too.

[aarya, 2016-07-15 17:19:42]

On 2016/07/15 17:17:43, Nico wrote:
> On 2016/07/15 17:16:00, inferno wrote:
> > On 2016/07/15 17:05:56, Nico wrote:
> > > inferno, lkgr doesn't need this either, does it?
> > 
> > This is needed for lkgr archived builds, we need to copy llvm-symbolizer to
> root
> > of that archive so that clusterfuzz bots can use latest version.
> 
> Can't the clusterfuzz bots use the one in
> third_party/llvm-build/Release+Asserts/bin instead? That's what all the other
> places do too.

ClusterFuzz bots don't have src checkout. Or are you suggesting we pick this
from clang archived builds. That would need lot of other wiring and we won't
know which clang archives map to which chromium revision builds. So, that is why
we include this in the chromium revision build archive itself.

[Nico, 2016-07-15 17:27:42]

On 2016/07/15 17:19:42, aarya wrote:
> On 2016/07/15 17:17:43, Nico wrote:
> > On 2016/07/15 17:16:00, inferno wrote:
> > > On 2016/07/15 17:05:56, Nico wrote:
> > > > inferno, lkgr doesn't need this either, does it?
> > > 
> > > This is needed for lkgr archived builds, we need to copy llvm-symbolizer
to
> > root
> > > of that archive so that clusterfuzz bots can use latest version.
> > 
> > Can't the clusterfuzz bots use the one in
> > third_party/llvm-build/Release+Asserts/bin instead? That's what all the
other
> > places do too.
> 
> ClusterFuzz bots don't have src checkout. Or are you suggesting we pick this
> from clang archived builds. That would need lot of other wiring and we won't
> know which clang archives map to which chromium revision builds. So, that is
why
> we include this in the chromium revision build archive itself.

Ah, I understand, thanks.

For swarming, //third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer.exe
gets bundled up to the swarming bots. The swarming bots don't have a src
checkout either, but they do have a src folder where this can be unpacked too.
Does clusterfuzz have something like this?

If not, maybe the cf_archive script could copy the symbolizer over. Having a
build edge for this that isn't really used is a bit weird.

[aarya, 2016-07-15 17:34:23]

On 2016/07/15 17:27:42, Nico wrote:
> On 2016/07/15 17:19:42, aarya wrote:
> > On 2016/07/15 17:17:43, Nico wrote:
> > > On 2016/07/15 17:16:00, inferno wrote:
> > > > On 2016/07/15 17:05:56, Nico wrote:
> > > > > inferno, lkgr doesn't need this either, does it?
> > > > 
> > > > This is needed for lkgr archived builds, we need to copy llvm-symbolizer
> to
> > > root
> > > > of that archive so that clusterfuzz bots can use latest version.
> > > 
> > > Can't the clusterfuzz bots use the one in
> > > third_party/llvm-build/Release+Asserts/bin instead? That's what all the
> other
> > > places do too.
> > 
> > ClusterFuzz bots don't have src checkout. Or are you suggesting we pick this
> > from clang archived builds. That would need lot of other wiring and we won't
> > know which clang archives map to which chromium revision builds. So, that is
> why
> > we include this in the chromium revision build archive itself.
> 
> Ah, I understand, thanks.
> 
> For swarming, //third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer.exe
> gets bundled up to the swarming bots. The swarming bots don't have a src
> checkout either, but they do have a src folder where this can be unpacked too.
> Does clusterfuzz have something like this?

I don't know how this works. Can you point to source.

> 
> If not, maybe the cf_archive script could copy the symbolizer over. Having a
> build edge for this that isn't really used is a bit weird.

Yes clusterfuzz_archive script makes lot of sense here -
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/archive/a....
if you can move this there, than sounds good. Also, we need objdump in a similar
way, see https://bugs.chromium.org/p/chromium/issues/detail?id=430156#c40.

[Nico, 2016-07-15 17:44:28]

Description was changed from

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

BUG=none
==========

to

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

BUG=none, vaguely related to 430156 and 495204
==========

[Nico, 2016-12-03 00:26:27]

thakis@chromium.org changed reviewers:
+ ochang@chromium.org

[Nico, 2016-12-03 00:26:27]

After  https://codereview.chromium.org/2394163006/ , is this good to go now?

[inferno, 2016-12-03 17:17:11]

On 2016/12/03 00:26:27, Nico wrote:
> After  https://codereview.chromium.org/2394163006/ , is this good to go now?

Should be, but i will let Oliver confirm.

[Nico, 2016-12-05 20:52:06]

ochang: does this look fine?

[Oliver Chang, 2016-12-05 20:53:05]

On 2016/12/05 20:52:06, Nico wrote:
> ochang: does this look fine?

Yep, should be good as far as the builders we care about are concerned.

[Nico, 2016-12-05 21:01:37]

can i get an lg then? :-)

On Mon, Dec 5, 2016 at 3:53 PM, <ochang@chromium.org> wrote:

> On 2016/12/05 20:52:06, Nico wrote:
> > ochang: does this look fine?
>
> Yep, should be good as far as the builders we care about are concerned.
>
> https://codereview.chromium.org/2145833008/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Oliver Chang, 2016-12-05 21:02:09]

lgtm

[inferno, 2016-12-05 21:03:05]

lgtm

[Nico, 2016-12-07 16:01:14]

Description was changed from

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

BUG=none, vaguely related to 430156 and 495204
==========

to

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

Clusterfuzz used to need this, but it stopped needing it in
https://codereview.chromium.org/2394163006/ 

BUG=none, vaguely related to 430156 and 495204
==========

[Nico, 2016-12-07 16:01:51]

Description was changed from

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

Clusterfuzz used to need this, but it stopped needing it in
https://codereview.chromium.org/2394163006/ 

BUG=none, vaguely related to 430156 and 495204
==========

to

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

Clusterfuzz used to need this, but it stopped needing it in
https://codereview.chromium.org/2394163006/

No intentional behavior change.

BUG=none, vaguely related to 430156 and 495204
==========

[Nico, 2016-12-07 16:02:10]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-12-07 16:02:10]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org,
inferno@chromium.org
Link to the patchset: https://codereview.chromium.org/2145833008/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-07 16:02:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 17:05:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481126530288080,
"parent_rev": "6337cf110e0e396e08434576291f6f9b0e25d6d3", "commit_rev":
"473f6922301746d1ff9b7598fd555a437dcc0b5b"}

[commit-bot: I haz the power, 2016-12-07 17:06:05]

Description was changed from

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

Clusterfuzz used to need this, but it stopped needing it in
https://codereview.chromium.org/2394163006/

No intentional behavior change.

BUG=none, vaguely related to 430156 and 495204
==========

to

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

Clusterfuzz used to need this, but it stopped needing it in
https://codereview.chromium.org/2394163006/

No intentional behavior change.

BUG=none, vaguely related to 430156 and 495204
==========

[commit-bot: I haz the power, 2016-12-07 17:06:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 17:09:12]

Description was changed from

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

Clusterfuzz used to need this, but it stopped needing it in
https://codereview.chromium.org/2394163006/

No intentional behavior change.

BUG=none, vaguely related to 430156 and 495204
==========

to

==========
Remove step that copies llvm-symbolizer to the root build dir.

As far as I can tell, everything references the original location of
llvm-symbolizer in third_party/llvm-build/Release+Asserts/bin, so
this shouldn't be needed.

Clusterfuzz used to need this, but it stopped needing it in
https://codereview.chromium.org/2394163006/

No intentional behavior change.

BUG=none, vaguely related to 430156 and 495204

Committed: https://crrev.com/eeaccfd53c4d582d39ec7e30f19d8e4db8b4ee49
Cr-Commit-Position: refs/heads/master@{#436986}
==========

[commit-bot: I haz the power, 2016-12-07 17:09:13]

Patchset 2 (id:??) landed as
https://crrev.com/eeaccfd53c4d582d39ec7e30f19d8e4db8b4ee49
Cr-Commit-Position: refs/heads/master@{#436986}