Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: components/arc/user_data/arc_user_data_service.h

Issue 2145813002: Clear old ARC instance before opt-in. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/user_data/arc_user_data_service.h
diff --git a/components/arc/user_data/arc_user_data_service.h b/components/arc/user_data/arc_user_data_service.h
index 38ea0f99973ec2f98025405f19e21c3a2fc22df4..c5d76cd54134c0bea10be712d9d750dc4082e49b 100644
--- a/components/arc/user_data/arc_user_data_service.h
+++ b/components/arc/user_data/arc_user_data_service.h
@@ -11,9 +11,12 @@
#include "base/threading/thread_checker.h"
#include "components/arc/arc_bridge_service.h"
#include "components/arc/arc_service.h"
+#include "components/prefs/pref_change_registrar.h"
#include "components/prefs/pref_member.h"
#include "components/signin/core/account_id/account_id.h"
+class PrefService;
+
namespace arc {
class ArcBridgeService;
@@ -26,6 +29,7 @@ class ArcUserDataService : public ArcService,
explicit ArcUserDataService(
ArcBridgeService* arc_bridge_service,
std::unique_ptr<BooleanPrefMember> arc_enabled_pref,
+ PrefService* pref_service,
const AccountId& account_id);
~ArcUserDataService() override;
@@ -41,11 +45,26 @@ class ArcUserDataService : public ArcService,
// removal of user data if both conditions are true.
void ClearIfDisabled();
+ // Callback when the kArcEnabled preference changes. It watches for instances
+ // where the preference is disabled and remembers this so that it can wipe
+ // user data once the bridge has stopped.
+ void OnOptInPreferenceChanged();
+
const std::unique_ptr<BooleanPrefMember> arc_enabled_pref_;
// Account ID for the account for which we currently have opt-in information.
AccountId primary_user_account_id_;
+ // Registrar used to monitor ARC enabled state.
+ PrefChangeRegistrar pref_change_registrar_;
+
+ // Set to true when kArcEnabled goes from true to false and set to false
+ // again after user data has been wiped. This ensures data is wiped even if
+ // the user tries to enable ARC before the bridge has shut down.
+ bool arc_disabled_ = false;
+
+ base::WeakPtrFactory<ArcUserDataService> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ArcUserDataService);
};

Powered by Google App Engine
This is Rietveld 408576698