Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Side by Side Diff: components/arc/user_data/arc_user_data_service.cc

Issue 2145813002: Clear old ARC instance before opt-in. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/arc/user_data/arc_user_data_service.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/user_data/arc_user_data_service.h" 5 #include "components/arc/user_data/arc_user_data_service.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "chromeos/chromeos_switches.h" 10 #include "chromeos/chromeos_switches.h"
11 #include "chromeos/cryptohome/cryptohome_parameters.h" 11 #include "chromeos/cryptohome/cryptohome_parameters.h"
12 #include "chromeos/dbus/dbus_thread_manager.h" 12 #include "chromeos/dbus/dbus_thread_manager.h"
13 #include "chromeos/dbus/session_manager_client.h" 13 #include "chromeos/dbus/session_manager_client.h"
14 #include "components/prefs/pref_member.h" 14 #include "components/prefs/pref_member.h"
15 #include "components/signin/core/account_id/account_id.h" 15 #include "components/signin/core/account_id/account_id.h"
16 #include "components/user_manager/user_manager.h" 16 #include "components/user_manager/user_manager.h"
17 17
18 namespace arc { 18 namespace arc {
19 19
20 ArcUserDataService::ArcUserDataService( 20 ArcUserDataService::ArcUserDataService(
21 ArcBridgeService* bridge_service, 21 ArcBridgeService* bridge_service,
22 std::unique_ptr<BooleanPrefMember> arc_enabled_pref, 22 std::unique_ptr<BooleanPrefMember> arc_enabled_pref,
23 const AccountId& account_id) 23 const AccountId& account_id)
24 : ArcService(bridge_service), 24 : ArcService(bridge_service),
25 arc_enabled_pref_(std::move(arc_enabled_pref)), 25 arc_enabled_pref_(std::move(arc_enabled_pref)),
26 primary_user_account_id_(account_id) { 26 primary_user_account_id_(account_id),
27 weak_ptr_factory_(this) {
27 arc_bridge_service()->AddObserver(this); 28 arc_bridge_service()->AddObserver(this);
29 pref_change_registrar_.Init(arc_enabled_pref_->prefs());
30 pref_change_registrar_.Add(
31 arc_enabled_pref_->GetPrefName(),
32 base::Bind(&ArcUserDataService::OnOptInPreferenceChanged,
33 weak_ptr_factory_.GetWeakPtr()));
28 ClearIfDisabled(); 34 ClearIfDisabled();
29 } 35 }
30 36
31 ArcUserDataService::~ArcUserDataService() { 37 ArcUserDataService::~ArcUserDataService() {
32 DCHECK(thread_checker_.CalledOnValidThread()); 38 DCHECK(thread_checker_.CalledOnValidThread());
33 arc_bridge_service()->RemoveObserver(this); 39 arc_bridge_service()->RemoveObserver(this);
34 } 40 }
35 41
36 void ArcUserDataService::OnBridgeStopped(ArcBridgeService::StopReason reason) { 42 void ArcUserDataService::OnBridgeStopped(ArcBridgeService::StopReason reason) {
37 DCHECK(thread_checker_.CalledOnValidThread()); 43 DCHECK(thread_checker_.CalledOnValidThread());
38 const AccountId& account_id = 44 const AccountId& account_id =
39 user_manager::UserManager::Get()->GetPrimaryUser()->GetAccountId(); 45 user_manager::UserManager::Get()->GetPrimaryUser()->GetAccountId();
40 if (account_id != primary_user_account_id_) { 46 if (account_id != primary_user_account_id_) {
41 LOG(ERROR) << "User preferences not loaded for " 47 LOG(ERROR) << "User preferences not loaded for "
42 << primary_user_account_id_.GetUserEmail() 48 << primary_user_account_id_.GetUserEmail()
43 << ", but current primary user is " << account_id.GetUserEmail(); 49 << ", but current primary user is " << account_id.GetUserEmail();
44 primary_user_account_id_ = EmptyAccountId(); 50 primary_user_account_id_ = EmptyAccountId();
45 return; 51 return;
46 } 52 }
47 ClearIfDisabled(); 53 ClearIfDisabled();
48 } 54 }
49 55
50 void ArcUserDataService::ClearIfDisabled() { 56 void ArcUserDataService::ClearIfDisabled() {
51 DCHECK(thread_checker_.CalledOnValidThread()); 57 DCHECK(thread_checker_.CalledOnValidThread());
52 if (!arc_bridge_service()->stopped()) { 58 if (!arc_bridge_service()->stopped()) {
53 LOG(ERROR) << "ARC instance not stopped, user data can't be cleared"; 59 LOG(ERROR) << "ARC instance not stopped, user data can't be cleared";
54 return; 60 return;
55 } 61 }
56 if (arc_enabled_pref_->GetValue() || 62 if ((arc_enabled_pref_->GetValue() && !arc_disabled_) ||
57 base::CommandLine::ForCurrentProcess()->HasSwitch( 63 base::CommandLine::ForCurrentProcess()->HasSwitch(
58 chromeos::switches::kDisableArcDataWipe)) { 64 chromeos::switches::kDisableArcDataWipe)) {
59 return; 65 return;
60 } 66 }
67 arc_disabled_ = false;
61 const cryptohome::Identification cryptohome_id(primary_user_account_id_); 68 const cryptohome::Identification cryptohome_id(primary_user_account_id_);
62 chromeos::SessionManagerClient* session_manager_client = 69 chromeos::SessionManagerClient* session_manager_client =
63 chromeos::DBusThreadManager::Get()->GetSessionManagerClient(); 70 chromeos::DBusThreadManager::Get()->GetSessionManagerClient();
64 session_manager_client->RemoveArcData(cryptohome_id); 71 session_manager_client->RemoveArcData(cryptohome_id);
65 } 72 }
66 73
74 void ArcUserDataService::OnOptInPreferenceChanged() {
75 if (!arc_enabled_pref_->GetValue())
76 arc_disabled_ = true;
77 }
78
67 } // namespace arc 79 } // namespace arc
OLDNEW
« no previous file with comments | « components/arc/user_data/arc_user_data_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698