Enable software compositing in renderer for win aura.

Enable software compositing in renderer for win aura.


BUG=229712, 261797, 253113
R=piman@chromium.org, zmo@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215975

[jbauman, 2013-08-02 01:30:56]

I'll probably try to turn this on for Chrome OS as well (at least temporarily)
after M30 branches.

[piman, 2013-08-02 01:46:20]

lgtm

[commit-bot: I haz the power, 2013-08-02 01:55:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/21458003/8001

[commit-bot: I haz the power, 2013-08-02 02:10:49]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[jbauman, 2013-08-02 12:03:00]

zmo@, could you do an OWNERS review of this?

[Zhenyao Mo, 2013-08-02 17:18:15]

On 2013/08/02 12:03:00, jbauman wrote:
> zmo@, could you do an OWNERS review of this?

LGTM

[commit-bot: I haz the power, 2013-08-02 23:05:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/21458003/8001

[commit-bot: I haz the power, 2013-08-03 00:31:52]

Retried try job too often on linux_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[jbauman, 2013-08-03 08:54:41]

Among other things, looks like TabCaptureApiTest.ApiTests is failing
because the test compositor doesn't support doing RequestCopyOfOutput
correctly.


On Fri, Aug 2, 2013 at 5:31 PM, <commit-bot@chromium.org> wrote:

> Retried try job too often on linux_aura for step(s) content_browsertests
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=linux_**aura&number=65820<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=65820>
>
>
https://chromiumcodereview.**appspot.com/21458003/<https://chromiumcodereview...
>

[danakj, 2013-08-03 14:37:56]

Hm, so I just switched the browser compositor to use cc::TestWGC3D when its
not using real contexts, and we have unit tests that do async readbacks in
cc/ with that thing. I had to put a bunch of work into the TestWGC3D to
make them work, by adding fake buffer support.

If I had to guess, maybe the GLRenderer is trying to use something on the
context that isn't faked out and always returns 0 or the like, and so that
part of the readback is failing. IMHO it'd be worth making it pass, then we
can unit test more things.




On Sat, Aug 3, 2013 at 4:54 AM, John Bauman <jbauman@chromium.org> wrote:

> Among other things, looks like TabCaptureApiTest.ApiTests is failing
> because the test compositor doesn't support doing RequestCopyOfOutput
> correctly.
>
>
> On Fri, Aug 2, 2013 at 5:31 PM, <commit-bot@chromium.org> wrote:
>
>> Retried try job too often on linux_aura for step(s) content_browsertests
>> http://build.chromium.org/p/**tryserver.chromium/**
>>
buildstatus?builder=linux_**aura&number=65820<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=65820>
>>
>>
https://chromiumcodereview.**appspot.com/21458003/<https://chromiumcodereview...
>>
>
>

[jbauman, 2013-08-05 21:28:41]

On 2013/08/03 14:37:56, danakj wrote:
> Hm, so I just switched the browser compositor to use cc::TestWGC3D when its
> not using real contexts, and we have unit tests that do async readbacks in
> cc/ with that thing. I had to put a bunch of work into the TestWGC3D to
> make them work, by adding fake buffer support.
> 
> If I had to guess, maybe the GLRenderer is trying to use something on the
> context that isn't faked out and always returns 0 or the like, and so that
> part of the readback is failing. IMHO it'd be worth making it pass, then we
> can unit test more things.
> 

For me at least, it looks like the call the genMailboxCHROMIUM in
cc::GLRenderer::GetFramebufferPixelsAsync is being miscompiled. It's instead
calling a completely different (empty) function on the TestWebGraphicsContext3D.
So ideally that would be fixed.
> 
> 
> 
> On Sat, Aug 3, 2013 at 4:54 AM, John Bauman <mailto:jbauman@chromium.org>
wrote:
> 
> > Among other things, looks like TabCaptureApiTest.ApiTests is failing
> > because the test compositor doesn't support doing RequestCopyOfOutput
> > correctly.
> >
> >
> > On Fri, Aug 2, 2013 at 5:31 PM, <mailto:commit-bot@chromium.org> wrote:
> >
> >> Retried try job too often on linux_aura for step(s) content_browsertests
> >> http://build.chromium.org/p/**tryserver.chromium/**
> >>
>
buildstatus?builder=linux_**aura&number=65820<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=65820>
> >>
> >>
>
https://chromiumcodereview.**appspot.com/21458003/%3Chttps://chromiumcoderevi...>
> >>
> >
> >