Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2145793002: Enable PaymentRequest on Android by default. (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable PaymentRequest on Android by default. BUG=627648 Committed: https://crrev.com/59899871c544eb16d31c31b6eb761f83de00fd7d Cr-Commit-Position: refs/heads/master@{#406631}

Patch Set 1 #

Patch Set 2 : Fix test crash #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : Rename feature to WebPayments #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
please use gerrit instead
mek@, dfalcantara@, FYI. This is how I plan to enable PaymentRequest when it's ready to ...
4 years, 5 months ago (2016-07-12 23:30:35 UTC) #2
please use gerrit instead
mek@ & dfalcantara@, ptal patch 3. PaymentRequest is in a shippable state. We are getting ...
4 years, 5 months ago (2016-07-15 23:37:11 UTC) #5
Marijn Kruisselbrink
lgtm
4 years, 5 months ago (2016-07-18 16:43:56 UTC) #8
gone
lgtm
4 years, 5 months ago (2016-07-18 19:15:42 UTC) #9
please use gerrit instead
esprehn@, owners ptal in patch 3: content/child/runtime_features.cc third_party/WebKit/Source/web/WebRuntimeFeatures.cpp third_party/WebKit/public/web/WebRuntimeFeatures.h nasko@, owners ptal in patch 3: ...
4 years, 5 months ago (2016-07-18 23:16:42 UTC) #11
nasko
https://codereview.chromium.org/2145793002/diff/40001/content/public/common/content_features.cc File content/public/common/content_features.cc (right): https://codereview.chromium.org/2145793002/diff/40001/content/public/common/content_features.cc#newcode155 content/public/common/content_features.cc:155: const base::Feature kPaymentRequest{"PaymentRequest", "Web payments API" seems a bit ...
4 years, 5 months ago (2016-07-18 23:37:42 UTC) #12
please use gerrit instead
nasko@, ptal patch 4. https://codereview.chromium.org/2145793002/diff/40001/content/public/common/content_features.cc File content/public/common/content_features.cc (right): https://codereview.chromium.org/2145793002/diff/40001/content/public/common/content_features.cc#newcode155 content/public/common/content_features.cc:155: const base::Feature kPaymentRequest{"PaymentRequest", On 2016/07/18 ...
4 years, 5 months ago (2016-07-19 00:23:23 UTC) #15
Ilya Sherman
histograms.xml lgtm
4 years, 5 months ago (2016-07-19 01:17:19 UTC) #16
nasko
content/ LGTM
4 years, 5 months ago (2016-07-19 16:16:00 UTC) #19
esprehn
lgtm
4 years, 5 months ago (2016-07-20 16:13:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145793002/80001
4 years, 5 months ago (2016-07-20 17:17:37 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-20 18:57:48 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 18:57:52 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 19:02:26 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/59899871c544eb16d31c31b6eb761f83de00fd7d
Cr-Commit-Position: refs/heads/master@{#406631}

Powered by Google App Engine
This is Rietveld 408576698