Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2145753010: Fix JSON.stringify behavior for Dart Lists faking being arrays by adding stringify method. Test is … (Closed)

Created:
4 years, 5 months ago by Jacob
Modified:
4 years, 5 months ago
Reviewers:
Alan Knight
CC:
reviews+dom_dartlang.org
Base URL:
https://chromium.googlesource.com/dart/dartium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix JSON.stringify behavior for Dart Lists faking being arrays by adding stringify method. Test is in a separate regular Dart repo cl of dart2js fixes and extra test cases. BUG= R=alanknight@google.com Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=96537e884fb539ddb65f16262e350cc6a099da9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/bindings/core/dart/DartJsInterop.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
4 years, 5 months ago (2016-07-16 00:17:49 UTC) #2
Alan Knight
lgtm
4 years, 5 months ago (2016-07-19 16:55:48 UTC) #3
Jacob
4 years, 5 months ago (2016-07-19 17:12:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96537e884fb539ddb65f16262e350cc6a099da9a (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698