Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2145753006: Follow up to r37787: Put even more AST nodes into local_zone_. (Closed)

Created:
4 years, 5 months ago by marja
Modified:
4 years, 5 months ago
Reviewers:
titzer, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Follow up to r37787: Put even more AST nodes into local_zone_. BUG= Committed: https://crrev.com/517797534628c055700a567244a111d14f403c24 Cr-Commit-Position: refs/heads/master@{#37816}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/ast/ast.h View 1 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
marja
Here's more of the same, ptal. I could've done it all in one CL but ...
4 years, 5 months ago (2016-07-15 09:43:28 UTC) #4
titzer
On 2016/07/15 09:43:28, marja wrote: > Here's more of the same, ptal. > > I ...
4 years, 5 months ago (2016-07-15 11:13:34 UTC) #7
marja
Yeah, because of FuncNameInferrer; we put the FunctionLiteral there. Fixed!
4 years, 5 months ago (2016-07-15 11:54:26 UTC) #10
titzer
lgtm
4 years, 5 months ago (2016-07-15 12:22:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145753006/20001
4 years, 5 months ago (2016-07-15 12:30:48 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19571)
4 years, 5 months ago (2016-07-15 12:34:25 UTC) #17
marja
rossberg@, ptal (you're owner of ast/)
4 years, 5 months ago (2016-07-15 12:36:35 UTC) #19
rossberg
lgtm
4 years, 5 months ago (2016-07-15 12:57:11 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145753006/20001
4 years, 5 months ago (2016-07-18 07:36:36 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 08:04:12 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 08:04:17 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 08:05:15 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/517797534628c055700a567244a111d14f403c24
Cr-Commit-Position: refs/heads/master@{#37816}

Powered by Google App Engine
This is Rietveld 408576698