|
|
DescriptionFollow up to r37787: Put even more AST nodes into local_zone_.
BUG=
Committed: https://crrev.com/517797534628c055700a567244a111d14f403c24
Cr-Commit-Position: refs/heads/master@{#37816}
Patch Set 1 #Patch Set 2 : fix #Messages
Total messages: 26 (14 generated)
The CQ bit was checked by marja@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
marja@chromium.org changed reviewers: + titzer@chromium.org
Here's more of the same, ptal. I could've done it all in one CL but I wanted to be overly careful; the DoExpression stuff was added after local_zone_ whereas these things were already there.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
On 2016/07/15 09:43:28, marja wrote: > Here's more of the same, ptal. > > I could've done it all in one CL but I wanted to be overly careful; the > DoExpression stuff was added after local_zone_ whereas these things were already > there. Looks like one of these is causing tests to fail; my guess is FunctionLiteral. Otherwise looks good.
The CQ bit was checked by marja@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Yeah, because of FuncNameInferrer; we put the FunctionLiteral there. Fixed!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by marja@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19571)
marja@chromium.org changed reviewers: + rossberg@chromium.org
rossberg@, ptal (you're owner of ast/)
lgtm
The CQ bit was checked by marja@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Follow up to r37787: Put even more AST nodes into local_zone_. BUG= ========== to ========== Follow up to r37787: Put even more AST nodes into local_zone_. BUG= Committed: https://crrev.com/517797534628c055700a567244a111d14f403c24 Cr-Commit-Position: refs/heads/master@{#37816} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/517797534628c055700a567244a111d14f403c24 Cr-Commit-Position: refs/heads/master@{#37816} |