Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2145753002: (Reland) Add effect node support in PaintArtifactCompositor for layer list mode [4/4] (Closed)

Created:
4 years, 5 months ago by trchen
Modified:
4 years, 5 months ago
Reviewers:
pdr.
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland) Add effect node support in PaintArtifactCompositor for layer list mode [4/4] This CL adds a local EffectStack class similar to ClipManager, that keep track of effect state and assign generated cc effect node to layers. This is only used for layer list mode. BUG=609937 Committed: https://crrev.com/0ab96293282e024c9f54c956ba0c8a675ae8c6db Cr-Commit-Position: refs/heads/master@{#405432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -23 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 5 chunks +112 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 11 chunks +71 lines, -21 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
trchen
Nothing changed. Need to have https://codereview.chromium.org/2140173004/ first.
4 years, 5 months ago (2016-07-12 22:39:59 UTC) #2
trchen
I made it a TBR because nothing changed. Please let me know if you want ...
4 years, 5 months ago (2016-07-13 21:39:16 UTC) #4
pdr.
On 2016/07/13 at 21:39:16, trchen wrote: > I made it a TBR because nothing changed. ...
4 years, 5 months ago (2016-07-13 22:56:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145753002/1
4 years, 5 months ago (2016-07-14 02:16:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 04:11:05 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 04:13:22 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ab96293282e024c9f54c956ba0c8a675ae8c6db
Cr-Commit-Position: refs/heads/master@{#405432}

Powered by Google App Engine
This is Rietveld 408576698