Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2145723002: gcapi_mac: Support installation on macOS 10.12 (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gcapi_mac: Support installation on macOS 10.12 BUG=627576 Committed: https://crrev.com/95394dc224fb4b769da0025b87d264acb7946eca Cr-Commit-Position: refs/heads/master@{#404860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/installer/gcapi_mac/gcapi.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mark Mentovai
4 years, 5 months ago (2016-07-12 19:59:03 UTC) #2
Nico
lgtm job security!
4 years, 5 months ago (2016-07-12 20:02:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145723002/1
4 years, 5 months ago (2016-07-12 20:06:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 23:40:46 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 23:42:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95394dc224fb4b769da0025b87d264acb7946eca
Cr-Commit-Position: refs/heads/master@{#404860}

Powered by Google App Engine
This is Rietveld 408576698