Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2145683004: [turbofan] Make sure value numbering only narrows types. (Closed)

Created:
4 years, 5 months ago by Jarin
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make sure value numbering only narrows types. Committed: https://crrev.com/97b886a2b07d1773333625010d8be07e17af2af2 Cr-Commit-Position: refs/heads/master@{#37745}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M src/compiler/pipeline.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/value-numbering-reducer.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/value-numbering-reducer.cc View 1 5 chunks +19 lines, -6 lines 0 comments Download
M test/unittests/compiler/value-numbering-reducer-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Jarin
Could you take a look, please?
4 years, 5 months ago (2016-07-13 14:58:18 UTC) #4
Benedikt Meurer
LGTM.
4 years, 5 months ago (2016-07-14 08:07:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145683004/20001
4 years, 5 months ago (2016-07-14 08:07:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 08:09:23 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 08:10:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97b886a2b07d1773333625010d8be07e17af2af2
Cr-Commit-Position: refs/heads/master@{#37745}

Powered by Google App Engine
This is Rietveld 408576698