Adding visualmetrics code under third_party for speedindex calculations.

Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py  succeeded.

BUG=630746
Committed: https://crrev.com/984ad5ceb395a0f89f1b77c18433bd5b1508bcc6
Cr-Commit-Position: refs/heads/master@{#409292}

[prabhur1, 2016-07-12 18:46:03]

Description was changed from

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

BUG=
==========

to

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py 
succeeded.

BUG=
==========

[prabhur1, 2016-07-12 18:46:03]

prabhur@chromium.org changed reviewers:
+ nyquist@chromium.org, pmeenan@chromium.org

[prabhur1, 2016-07-12 18:47:44]

Hi Tommy/Patrick
Could you please take a look, before going to the chrome-eng-review & other
groups for approval.

Thanks!

[Pat Meenan, 2016-07-12 18:59:26]

lgtm

[nyquist, 2016-07-15 20:48:54]

So, do we really need to check this in directly to the chromium repository? That
makes it much harder to roll in new functionality or update it from upstream.
I'd almost argue you should add a tool for that then.

Could we instead add a mirror to the GitHub repo, and then just add it to
src/DEPS? We often have for example
src/third_party/visualmetrics/README.chromium (and related files such as GN
files if necessary). And then the code can be checked out to
src/third_party/visualmetrics/src.

src/third_party/visualmetrics/src -->
https://chromium.googlesource.com/external/github.com/WPO-Foundation/visualme...

So basically just create a ticket for the component 	
Infra>Git>Admin, asking to mirror
https://github.com/WPO-Foundation/visualmetrics.
They will probably put it at the URL I mentioned above, and then your CL will
then only include the DEPS-change, the OWNERS-file and the README.chromium file.
I think the README.chromium file probably can point to the one in the repo.

That should simplify future updates a lot! :-)

[prabhur1, 2016-07-22 20:40:49]

Thanks for the pointers. That helped a lot!!
Should I create the ticket before or after approval from the chrome-eng-reviews
?
PTAL.

[nyquist, 2016-07-22 20:59:08]

On 2016/07/22 20:40:49, prabhur1 wrote:
> Thanks for the pointers. That helped a lot!!
> Should I create the ticket before or after approval from the
chrome-eng-reviews
> ?
> PTAL.

I asked the chrome infra team the same question. They said they could just
remove it again if it was denied, so just file the ticket to create the repo
now.

[nyquist, 2016-07-22 21:00:51]

https://codereview.chromium.org/2145673002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/2145673002/diff/20001/DEPS#newcode287
DEPS:287: 'src/third_party/visualmetrics/src':
Do we need this for os=android only?

[prabhur1, 2016-07-22 21:18:27]

On 2016/07/22 20:59:08, nyquist wrote:
> On 2016/07/22 20:40:49, prabhur1 wrote:
> > Thanks for the pointers. That helped a lot!!
> > Should I create the ticket before or after approval from the
> chrome-eng-reviews
> > ?
> > PTAL.
> 
> I asked the chrome infra team the same question. They said they could just
> remove it again if it was denied, so just file the ticket to create the repo
> now.

Ok. will do.

[prabhur1, 2016-07-22 21:18:39]

https://codereview.chromium.org/2145673002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/2145673002/diff/20001/DEPS#newcode287
DEPS:287: 'src/third_party/visualmetrics/src':
On 2016/07/22 21:00:51, nyquist wrote:
> Do we need this for os=android only?

This is useful for desktop Chrome as well. So just leave it here ?

[nyquist, 2016-07-22 21:23:37]

sgtm. lgtm to land when the mirror has been set up. I trust you not to land it
before that is ready :-)

Could you also edit the CL description to refer to the bug that adds the mirror?

[prabhur1, 2016-07-22 21:27:46]

Description was changed from

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py 
succeeded.

BUG=
==========

to

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py 
succeeded.

Bug to create mirror: crbug/630746

BUG=
==========

[prabhur1, 2016-07-22 21:29:08]

On 2016/07/22 21:23:37, nyquist wrote:
> sgtm. lgtm to land when the mirror has been set up. I trust you not to land it
> before that is ready :-)
> 
> Could you also edit the CL description to refer to the bug that adds the
mirror?

Thanks! This still needs to go through eng-review before landing, correct ?
I will send the CL to the review list, if so.

[nyquist, 2016-07-22 21:30:33]

Yes. Now is a good time to kick off both that and the mirroring.

[nyquist, 2016-07-22 21:30:45]

Description was changed from

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py 
succeeded.

Bug to create mirror: crbug/630746

BUG=
==========

to

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py 
succeeded.

BUG=630746
==========

[prabhur1, 2016-07-25 17:42:25]

Added .gitignore.

[Martin Barbella, 2016-07-25 18:29:02]

mbarbella@chromium.org changed reviewers:
+ mbarbella@chromium.org

[Martin Barbella, 2016-07-25 18:29:02]

lgtm from security since this appears to be non-shipping.

[xam, 2016-07-28 01:30:26]

On 2016/07/25 18:29:02, Martin Barbella wrote:
> lgtm from security since this appears to be non-shipping.

LGTM from osptr

[prabhur1, 2016-08-02 18:52:58]

On 2016/07/28 01:30:26, xam wrote:
> On 2016/07/25 18:29:02, Martin Barbella wrote:
> > lgtm from security since this appears to be non-shipping.
> 
> LGTM from osptr

The mirror has been created and I tested it.
Checking this in.
https://bugs.chromium.org/p/chromium/issues/detail?id=630746

[prabhur1, 2016-08-02 18:53:18]

The CQ bit was checked by prabhur@chromium.org

[prabhur1, 2016-08-02 18:53:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
pmeenan@chromium.org, nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/2145673002/#ps40001
(title: "Added visualmetrics to .gitignore")

[commit-bot: I haz the power, 2016-08-02 18:54:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 20:08:40]

Description was changed from

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py 
succeeded.

BUG=630746
==========

to

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py 
succeeded.

BUG=630746
==========

[commit-bot: I haz the power, 2016-08-02 20:08:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-02 20:11:14]

Description was changed from

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py 
succeeded.

BUG=630746
==========

to

==========
Adding visualmetrics code under third_party for speedindex calculations.
Visualmetrics python library is used to calculate speedindex score of a webpage
navigation.

src/tools/licenses.py scan & src/tools/checklicenses/checklicenses.py 
succeeded.

BUG=630746

Committed: https://crrev.com/984ad5ceb395a0f89f1b77c18433bd5b1508bcc6
Cr-Commit-Position: refs/heads/master@{#409292}
==========

[commit-bot: I haz the power, 2016-08-02 20:11:15]

Patchset 3 (id:??) landed as
https://crrev.com/984ad5ceb395a0f89f1b77c18433bd5b1508bcc6
Cr-Commit-Position: refs/heads/master@{#409292}