Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js

Issue 2145643005: MD Settings: Search engines page, open "manage extension" in new tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview A helper object used from the "Manage search engines" section 6 * @fileoverview A helper object used from the "Manage search engines" section
7 * to interact with the browser. 7 * to interact with the browser.
8 */ 8 */
9 9
10 /** 10 /**
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 'validateSearchEngineInput', fieldName, fieldValue); 124 'validateSearchEngineInput', fieldName, fieldValue);
125 }, 125 },
126 126
127 /** @override */ 127 /** @override */
128 disableExtension: function(extensionId) { 128 disableExtension: function(extensionId) {
129 chrome.send('disableExtension', [extensionId]); 129 chrome.send('disableExtension', [extensionId]);
130 }, 130 },
131 131
132 /** @override */ 132 /** @override */
133 manageExtension: function(extensionId) { 133 manageExtension: function(extensionId) {
134 window.location = 'chrome://extensions?id=' + extensionId; 134 window.open('chrome://extensions?id=' + extensionId);
135 }, 135 },
136 }; 136 };
137 137
138 return { 138 return {
139 SearchEnginesBrowserProxy: SearchEnginesBrowserProxy, 139 SearchEnginesBrowserProxy: SearchEnginesBrowserProxy,
140 SearchEnginesBrowserProxyImpl: SearchEnginesBrowserProxyImpl, 140 SearchEnginesBrowserProxyImpl: SearchEnginesBrowserProxyImpl,
141 }; 141 };
142 }); 142 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698