Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2145643005: MD Settings: Search engines page, open "manage extension" in new tab. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
tommycli, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Search engines page, open "manage extension" in new tab. BUG=619791 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/157635fc46d91566cff9cc44575d732936a9622e Cr-Commit-Position: refs/heads/master@{#404863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
dpapad
4 years, 5 months ago (2016-07-12 21:24:37 UTC) #3
Dan Beam
lgtm
4 years, 5 months ago (2016-07-12 21:29:05 UTC) #5
tommycli
lgtm
4 years, 5 months ago (2016-07-12 21:31:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145643005/1
4 years, 5 months ago (2016-07-12 21:40:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 00:18:45 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 00:19:51 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 00:21:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/157635fc46d91566cff9cc44575d732936a9622e
Cr-Commit-Position: refs/heads/master@{#404863}

Powered by Google App Engine
This is Rietveld 408576698