Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214563004: Oilpan: move WebKitPoint to the oilpan heap. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M Source/bindings/v8/custom/V8WebKitPointCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMPoint.h View 2 chunks +8 lines, -5 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/WebKitPoint.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
sof
Please take a look. Final piece in core/frame/
6 years, 9 months ago (2014-03-27 11:24:48 UTC) #1
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-27 11:41:41 UTC) #2
haraken
LGTM
6 years, 9 months ago (2014-03-27 11:50:57 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-27 11:52:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/214563004/1
6 years, 9 months ago (2014-03-27 11:52:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 12:16:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 12:16:28 UTC) #7
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-27 12:17:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/214563004/1
6 years, 9 months ago (2014-03-27 12:17:27 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 13:23:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 13:23:11 UTC) #11
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-27 13:24:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/214563004/1
6 years, 9 months ago (2014-03-27 13:25:10 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:32:02 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 14:32:02 UTC) #15
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-27 14:37:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/214563004/1
6 years, 9 months ago (2014-03-27 14:37:10 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:57:28 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 14:57:29 UTC) #19
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-27 18:40:08 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/214563004/1
6 years, 9 months ago (2014-03-27 18:40:15 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 19:55:09 UTC) #22
Message was sent while issue was closed. 
Change committed as 170199

Powered by Google App Engine
This is Rietveld 408576698