Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2145573002: Revert of Pre-crop filled rects to avoid scissor (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Pre-crop filled rects to avoid scissor (patchset #6 id:100001 of https://codereview.chromium.org/2132073002/ ) Reason for revert: I believe that this is breaking the roll. https://codereview.chromium.org/2141923002 https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/258434/steps/cc_unittests%20%28with%20patch%29%20on%20Mac-10.9/logs/stdio Original issue's description: > Pre-crop filled rects to avoid scissor > > Updates GrDrawContext to crop filled rects to the clip bounds before > creating batches for them. Also adds clipping logic to ignore scissor > when the draw falls completely inside. These two changes combined > reduce API traffic and improve batching. > > In the future this can and should be improved by switching to floating > point clip boundaries, thus allowing us to throw out non pixel aligned > rectangle clips as well. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2132073002 > > Committed: https://skia.googlesource.com/skia/+/7969838702135b9f127bd738728da61bc49b050a TBR=bsalomon@google.com,robertphillips@google.com,csmartdalton@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/aeadcdfbf203ccfedece9721d410192491815fc1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -220 lines) Patch
D gm/croppedrects.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
M include/gpu/GrClip.h View 1 chunk +0 lines, -20 lines 0 comments Download
M src/gpu/GrClip.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 3 chunks +6 lines, -10 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 7 chunks +11 lines, -75 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Pre-crop filled rects to avoid scissor
4 years, 5 months ago (2016-07-12 12:40:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145573002/1
4 years, 5 months ago (2016-07-12 12:40:36 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 12:40:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aeadcdfbf203ccfedece9721d410192491815fc1

Powered by Google App Engine
This is Rietveld 408576698